-
Notifications
You must be signed in to change notification settings - Fork 128
Maya: implement matchmove publishing #5445
Maya: implement matchmove publishing #5445
Conversation
This validator checks number of cameras, without optionality publish wouldn't be possible.
Task linked: OP-6360 Maya: multiple cameras publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - I don't think I'll be approving this from my end. This seems to go against the whole concept of what the camera
family is designed to be.
This just seems off. The whole intent for the camera family is to be a single camera - or maybe also a stereo camera (technically two lenses) but even then I'd say it's likely better to make that a stereoCamera
family to be explicit about the content.
What's the reason you need multiple cameras in a single camera instance as opposed to you just publishing multiple camera instances?
Or, if you want to put any amount of cameras into an instance without rules - why not use a pointcache instance?
The Houdini (loading) logic for example is also expecting it currently to be a single camera and I anticipate other hosts to be doing the same.
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
Changes to Ayon settings should also bump up version of addon.
I'll let @m-u-r-p-h-y or @antirotor reply to this. But thanks for valid concerns, I was expecting them. |
You could have a family called "cameras" that'll publish each camera collected as "camera" family. |
If this family is meant for one camera only,(we should check if we have single camera only present) and we need a multicamera family to cover the use case of publishing dozens or even hundreds of cameras used for photogrammetry model reconstruction (including corresponding image planes).
|
Pointcache family can export any amount of cameras + include geo or locators if needed. |
Number of cameras might be quite large, set operations will be faster than loop.
Image plane must be reattached before baked camera(s) are deleted.
Reattached image planes to original cameras (must have been wrong previously when testing). |
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…inal camera Without this image planes would disappear after removal of baked cameras.
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
openpype/hosts/maya/plugins/publish/extract_camera_mayaScene.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even tho now Publish
produces correct data with all connected ImagePlanes
and keyframes, there are few issues still.
- Matchmove Instance' s
Keep input connections
does not have any effect whenOFF
- Cameras having different names when published...this could be possible issue in some use cases ...now there is suffix present
_baked
in the names - I propose to change the terms
Camera (Alembic)
andCamera (Maya Scene)
in thematchmove
instance to
Extract Alembic
and Extract Maya Scene
Input connections are not copied anymore as they might be dangerous. It is possible to epxlicitly attach only image planes instead.
Copying input connections might be dangerous (rig etc.), it is possible to explicitly attach only image planes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all works as it should and matchMove
asset being correctly produced with ImagePlanes
just when Keep ImagePlanes
being Enabled
and vice versa.
There is also correctly publish Camera and its Scale
if animated, so all good!
Co-authored-by: Roy Nieterau <[email protected]>
…0_Maya-multiple-cameras-publish
had been fixed and user is not acting
Changelog Description
Add possibility to export multiple cameras in single
matchmove
family instance, both inabc
andma
.Exposed flag 'Keep image planes' to control export of image planes.
Additional info
Switch to
matchmove
fromcamera
family was chosen to don't break existing workflow where only single camera is expected (Houdini, Nuke). It is important to note, that alembic and maya scenes don't support identical feature, so it is possible to have richer matchmove data in .ma, compared to .abc format. For instance Image planes will not be preserved in .abc file.Testing notes:
1.create multiple cameras in Maya
2. select all of them and Create
matchmove
instance3. publish
4. try to load both via
Reference (abc)
andReferenca (ma)
, it should load all cameras (previously it would load only first camera even if you would select multiple for Creation step).