Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Optimize validate plug-in path attributes #5522

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Maya: Optimize validate plug-in path attributes #5522

merged 1 commit into from
Sep 1, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Aug 28, 2023

Changelog Description

  • Optimize query (use cmds.ls once)
  • Add Select Invalid action
  • Improve validation report
  • Avoid "Unknown object type" errors

Additional info

Example report output after this PR:
image

Testing notes:

  1. Set some invalid filepaths on node types that are checked by the plug-in's settings.

@BigRoy
Optimize query (use cmds.ls once), add Select Invalid action, impro…
d491b4f 
…ve validation report, avoid "Unknown object type" errors
@BigRoy BigRoy added type: enhancement Enhancements to existing functionality host: Maya community contribution labels Aug 28, 2023
@BigRoy BigRoy requested review from mkolar and moonyuet August 28, 2023 12:30
@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Aug 28, 2023
@moonyuet moonyuet requested a review from LiborBatek August 28, 2023 12:38
tokejepsen
tokejepsen approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Maya 2023 successfully and code looks good.

@iLLiCiTiT iLLiCiTiT merged commit d047d8d into ynput:develop Sep 1, 2023
5 checks passed
@ynbot ynbot added this to the next-patch milestone Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moonyuet moonyuet moonyuet left review comments

@kalisp kalisp kalisp left review comments

@tokejepsen tokejepsen tokejepsen approved these changes

@mkolar mkolar Awaiting requested review from mkolar

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@antirotor antirotor

Labels
community contribution host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.16.5
Development

Successfully merging this pull request may close these issues.
7 participants
@BigRoy @tokejepsen @kalisp @moonyuet @antirotor @iLLiCiTiT @ynbot