This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Igniter: Allow custom Qt scale factor rounding policy #5554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Do not force
PassThrough
rounding policy if different policy is defined via env variable.Additional info
On some virtual machines is
PassThrough
rounding policy causing issues with calculated widget rectangle and paint rectangle. Painted rectangle has expected rectangle, but handling of events happens in smaller and offset rectangle. Probably caused by some bug in Qt. Widgets on top left are closer to expected behavior, bottom right is worse.Testing notes:
You must have some scaling set (e.g. 125% on windows).
QT_SCALE_FACTOR_ROUNDING_POLICY
to e.g."Floor"