Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Yeti fix callback check per renderer used + validate once #5562

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Sep 4, 2023

Changelog Description

Validate Yeti Callback per renderer + check only once globally (ContextPlugin)

Additional info

This PR is dependent on https://github.com/ynput/OpenPype/pull/5559/files#diff-7b9879ee6c4f2db686b8338994be3031e3ccaf28f0d1d13bbd6fa46d48da1333 since that includes the ContextRepairAction implementation

Testing notes:

  1. Render with yeti callbacks in pre/post render scripts
  2. Ensure they are validated as expected

@BigRoy BigRoy added type: enhancement Enhancements to existing functionality host: Maya community contribution labels Sep 4, 2023
@ynbot ynbot added the size/S Denotes a PR changes 100-499 lines, ignoring general files label Sep 4, 2023
@LiborBatek
Copy link
Member

LiborBatek commented Sep 5, 2023

I have got issue with renderingMain instance and its validation and repair action...not sure whats going on (even if my workfile frame range matching the Database)

image

The case being my orig shot lenght was 1001-1050 (but with 5 frames handles at start and end) but I have changed it to the just 1001-1050)
Im not able to fix the frame range on renderMain tho (there isnt exposed frame range) and Repair not working.

Not sure if tied to this PR but definetely with the one you mentioned above.
image

and when triggered Repair on it I got following error log:

// Error: pyblish.plugin : Traceback (most recent call last):
//   File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
//     runner(*args)
//   File "D:\REPO\OpenPype\openpype\pipeline\publish\publish_plugins.py", line 243, in process
//     plugin.repair(instance)
//   File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\validate_frame_range.py", line 139, in repair
//     if cmds.attributeQuery("handleStart", node=node, exists=True):
// TypeError: No object matches name: renderLightingMain
// Traceback (most recent call last):
//   File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
//     runner(*args)
//   File "D:\REPO\OpenPype\openpype\pipeline\publish\publish_plugins.py", line 243, in process
//     plugin.repair(instance)
//   File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\validate_frame_range.py", line 139, in repair
//     if cmds.attributeQuery("handleStart", node=node, exists=True):
// TypeError: No object matches name: renderLightingMain

@BigRoy
Copy link
Collaborator Author

BigRoy commented Sep 5, 2023

Thanks @LiborBatek - the other PR does touch this validator, but doesn't touch code where it makes sense for this to be a newly introduced bug from that or this PR. Nonetheless, I'll look into the bug in a bit.

@LiborBatek
Copy link
Member

@BigRoy hi, any news on this one? so we can push it further? thx

@tokejepsen tokejepsen assigned BigRoy and unassigned LiborBatek Jan 16, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jan 16, 2024

Since the PR this one was dependent on is now closed (not merged) I'll close this one too.

Maybe in some time I can find time to slowly transfer a lot of our local fixes from our colorbleed repo.

@BigRoy BigRoy closed this Jan 16, 2024
@ynbot ynbot added this to the next-patch milestone Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community contribution host: Maya size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants