This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Remove shelf class and shelf build on maya userSetup.py
#5837
+0
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
added
host: Maya
type: refactor
ynbot
added
the
size/S
moonyuet
approved these changes
Nov 15, 2023
|
Agreed. this has been used on some old productions to build custom shelfs and clearly a legacy bit. We have a small conflict, but happy to merge when that is resolved. |
…hore/maya_shelf_build_cleanup # Conflicts: # openpype/hosts/maya/api/lib.py
|
@mkolar should be resolved now |
tokejepsen
approved these changes
Jan 23, 2024
antirotor
approved these changes
Feb 7, 2024
|
Yay, time for merging! 🚀 |
|
Shame to not merge this even though technically it should not make it to OP anymore. @bradenjennings could you please port it to ayon-core, so we can merge both at the same time? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Remove shelf builder logic. It appeared to be unused and had bugs.
Additional info
Bugs/unused:
self._nulleven though it didn't exist there.buildmethod - it didn't; it ran a preset dict.settings['maya'].get('project_shelf')which is not an existing key in project settings.OPENPYPE_PROJECT_SCRIPTSin the build but it's not set anywhere so will be confusing to anyone if it were to be run even (since it doesn't have settings you can't run it.)execcalls and could be potentially abused by someone savvy with ill intent.addMenuItemdidn't set the icon if it were passed@mkolar Do you know of someone somewhere potentially using this? It seemed originally coded by you but I have a feeling its ancient and now unused code.
Testing notes: