This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
+384
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improving logic of timeline fps distribution - rewriting constants and removing self.
Task linked: OP-7318 resolve: publishing issues |
ynbot
added
size/S
Denotes a PR changes 100-499 lines, ignoring general files
type: bug
Something isn't working
host: Resolve
labels
Nov 3, 2023
jakubjezek001
changed the title
Resolve: publishing fixes
Resolve: publishing improvements
Nov 3, 2023
For some reason, I am able to publish work files only. Creators do nothing in Resolve. |
hey.. here i am 🙃 |
iLLiCiTiT
reviewed
Nov 13, 2023
iLLiCiTiT
reviewed
Nov 13, 2023
self.log.debug("timeline_fps: {}".format(timeline_fps)) | ||
self.log.debug("media_fps: {}".format(media_fps)) | ||
if ( | ||
instance.context.data["hostName"] == "resolve" and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this logic be here if is "resolve" specific? Considering we'll be splitting all the parts into addons this can cause huge issues in future.
Could we get some testing notes on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
host: Resolve
port to AYON
size/S
Denotes a PR changes 100-499 lines, ignoring general files
sponsored
Client endorsed or requested
target: AYON
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Frame rate are now supported on multiple levels. Audio publishing is also supported.
Additional info
Testing notes: