Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Integration: 3DEqualizer integration #5868

Merged
merged 48 commits into from
Apr 30, 2024

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented Nov 3, 2023

Changelog Description

This PR is adding basic integration for 3DEqualizer4 from Science-D-Vision. Integration includes:

  • Workfiles
  • Loading plates (cameras)
  • Publishing scripts to Maya and Nuke
  • Publishing of lens data

Additional info

This integration is installing PySide2 into 3DEqualizer environment as it doesn't ship with Qt support. This comes with some price - to make Qt UI work with 3DEqualizer, processEvent() is periodically called. This is not optimal and it might create some issues, like 3Dequalizer crashing or UI lags.

For extraction, it is using 3de4 native scripts, but since they are depending on some UI, there are few hacks around it but I think it is better than rewritting the whole export logic to our plugins.

@antirotor antirotor added sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things host: 3DEqualizer labels Nov 3, 2023
@antirotor antirotor self-assigned this Nov 3, 2023
@ynbot
Copy link
Contributor

ynbot commented Nov 3, 2023

Task linked: OP-6032 3D Equalizer integration

@ynbot ynbot added size/XL Denotes a PR changes 1500-2499 lines, ignoring general files host: Maya host: Nuke labels Nov 3, 2023
openpype/hosts/equalizer/__init__.py Show resolved Hide resolved
openpype/hosts/equalizer/addon.py Outdated Show resolved Hide resolved
openpype/hosts/equalizer/api/host.py Outdated Show resolved Hide resolved
openpype/hosts/equalizer/api/host.py Show resolved Hide resolved
openpype/hosts/equalizer/tests/test_plugin.py Outdated Show resolved Hide resolved
openpype/lib/log.py Outdated Show resolved Hide resolved
server_addon/equalizer/LICENSE Outdated Show resolved Hide resolved
@seifibrahim32
Copy link

@antirotor I need to communicate with you please.

I have a 3DE4 with older version and I need your help to let me integrate it.
This version supports Python2.7

@antirotor
Copy link
Member Author

@antirotor I need to communicate with you please.

I have a 3DE4 with older version and I need your help to let me integrate it.
This version supports Python2.7

For that, you would have to change all py3 syntax like f-strings and type hints to py2.7 syntax. From older 3de API support I can't provide much assistance unfortunately.

@seifibrahim32
Copy link

seifibrahim32 commented Feb 12, 2024

@antirotor Frankly I exchanged it at the meantime with .format() as replacement to f-strings but I need to know more details for using hints for python2.7, please.

UPDATE: I understood you mean fixing interpreter hints for Py27 errors https://www.alexkorablev.com/typing-ci.html

@antirotor antirotor marked this pull request as ready for review April 15, 2024 12:24
@antirotor
Copy link
Member Author

I guess this can be merged as a base integration and I'll do port to AYON where it can be enhanced further

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 15, 2024

I guess this can be merged as a base integration and I'll do port to AYON where it can be enhanced further

I'd actually move forward and start effort on pushing this into a separate AYON addon - and closing this here. That's at least what I've seen happen with most other open OpenPype contributions? I believe @mkolar closed many of them?

@antirotor
Copy link
Member Author

Yeah, for AYON it will become separated, but since this is already done for OP and imho functioning, it would be pitty just not to merge it.

@antirotor antirotor merged commit 3e02224 into develop Apr 30, 2024
1 check passed
@ynbot ynbot added this to the next-patch milestone Apr 30, 2024
@antirotor
Copy link
Member Author

Port to ayon is done here ynput/ayon-equalizer#1

@antirotor antirotor deleted the feature/OP-6032_3dequalizer-integration branch April 30, 2024 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya host: Nuke host: 3DEqualizer port to AYON size/XL Denotes a PR changes 1500-2499 lines, ignoring general files sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants