-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
…equalizer-integration
…equalizer-integration
Task linked: OP-6032 3D Equalizer integration |
add support for mel script from 3dequalizer
…equalizer-integration
…equalizer-integration
@antirotor I need to communicate with you please. I have a 3DE4 with older version and I need your help to let me integrate it. |
For that, you would have to change all py3 syntax like f-strings and type hints to py2.7 syntax. From older 3de API support I can't provide much assistance unfortunately. |
@antirotor Frankly I exchanged it at the meantime with .format() as replacement to f-strings but I need to know more details for using hints for python2.7, please. UPDATE: I understood you mean fixing interpreter hints for Py27 errors https://www.alexkorablev.com/typing-ci.html |
I guess this can be merged as a base integration and I'll do port to AYON where it can be enhanced further |
I'd actually move forward and start effort on pushing this into a separate AYON addon - and closing this here. That's at least what I've seen happen with most other open OpenPype contributions? I believe @mkolar closed many of them? |
Yeah, for AYON it will become separated, but since this is already done for OP and imho functioning, it would be pitty just not to merge it. |
…ynput/OpenPype into feature/OP-6032_3dequalizer-integration
Port to ayon is done here ynput/ayon-equalizer#1 |
Changelog Description
This PR is adding basic integration for 3DEqualizer4 from Science-D-Vision. Integration includes:
Additional info
This integration is installing PySide2 into 3DEqualizer environment as it doesn't ship with Qt support. This comes with some price - to make Qt UI work with 3DEqualizer,
processEvent()
is periodically called. This is not optimal and it might create some issues, like 3Dequalizer crashing or UI lags.For extraction, it is using 3de4 native scripts, but since they are depending on some UI, there are few hacks around it but I think it is better than rewritting the whole export logic to our plugins.