-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
- against raw and content nodes together. - hidden nodes for extraction.
@antirotor doesn't this solve the issue with ASS we talked about int he office? |
I am little struggling with it but - if |
How about The workflow that is in place, is for proxy loading in the viewport. I think we should also get rid of the |
Yep, but we need to handle backwards compatibility with existing scenes |
@antirotor I think since the proxy workflow was broken due to #4460, there would only be roughly 2 months where people could have made valid proxy ass publishing. Then its been 1 year with the broken proxy workflow, which probably shows how much its used and that we dont need to worry about backward compatibility for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im constantly getting validation errors when putting geometries into ass
instance...
Im using the first type without Proxy
suffix
My geometries have some dependencies as they are skinned and with anim rig...but I can produce pointcache
for such selection easily for comparison...
So my question is, should be this instance type so limited?? as I dont see any point constrain it so much for the user... why I should care about something outside of actual publish instance aka ass
??
@LiborBatek could you show the instance or send me the workfile? |
@LiborBatek from the screen grab it looks like some geometries are being flagged as hidden but they might not be? To debug this, could you maybe send me the rig you are using? |
@LiborBatek I've found the bug that caused the validator to falsely flag nodes as hidden. Give it another test when you have time. |
openpype/hosts/maya/plugins/create/create_arnold_scene_source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did another testing round and all working fine and without any issues...
Changelog Description
This PR is to try and re-instate some flexibility to the
Arnold Scene Source
family, which got restricted by #4449The proxy workflow introduced was actually broken due to #4460.
We can now have any nodes directly in the instance set, which should be backwards compatible of the
Arnold Scene Source
before the overhaul in #4449.The
content
andproxy
sets works as well, but not at the same time as the raw nodes directly in the instance set. There is a validator in place to prevent using a single instance for both workflows.Now the question is whether we should have this as a single family or split somehow?
The workflow of having nodes directly in the instance set, compared to
content
andproxy
set, can be documented, so I see this as most a matter of terminology.Arnold Scene Source
makes sense to have as a family, but only if its a the raw output with little to no validation, similar toMaya Scene
. But then I'm not sure what to call the other family that has more of a workflow in place, which is similar toModel
andPointcache
.Testing notes:
content_SET
does not exists.