Release/3.16.9 quad 1.8.2 #6229

BenSouchet · 2024-02-21T14:28:32Z

No description provided.

…and add it to the condition which start the template build workfile (quadproduction/issues#123)

…irectly + enhance browsing node recursive function to handle more cases

…nd after the set_context_settings (quadproduction/issues#123)

…de-handle-settings' into release/3.16.9-quad-1.1.0

…ild-template-with-workfile' into release/3.16.9-quad-1.1.0

…h is created when a user script in installed)

…path

…ly keep lib/site-packages)

…hen-review-is-unchecked' into release/3.16.9-quad-1.1.0

Fix latest version (quadproduction/issues#101)

Release/3.16.9 quad 1.1.0

…ne addon with temporary file as target

…addon

…tput path

…er compatibility when replace paths parts

hound · 2024-02-21T14:28:55Z

openpype/client/server/conversion_utils.py

+            new_update_data["thumbnailId"] = data.pop("thumbnail_id")
+
+        if "tasks" in data:
+            tasks = data.pop("tasks")


local variable 'tasks' is assigned to but never used

hound · 2024-02-21T14:28:55Z

openpype/client/server/conversion_utils.py

+
+def _get_default_template_name(templates):
+    default_template = None
+    for name, template in templates.items():


Loop control variable 'template' not used within the loop body. If this is intended, start the name with an underscore.

hound · 2024-02-21T14:28:55Z

openpype/client/server/entity_links.py

+
+
+
+def get_linked_representation_id(


too many blank lines (3)

hound · 2024-02-21T14:28:55Z

openpype/client/server/operations.py

+                if body is not None:
+                    try:
+                        json.dumps(body)
+                    except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2024-02-21T14:28:55Z

openpype/client/server/operations.py

+                json.dumps(new_update_data, default=entity_data_json_default)
+            )
+
+        except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2024-02-21T14:28:55Z

openpype/client/server/operations.py

+                json.dumps(new_data, default=entity_data_json_default)
+            )
+
+        except:


Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'

hound · 2024-02-21T14:28:59Z

openpype/hosts/aftereffects/api/pipeline.py

-    if not _app:
-        print("Starting new QApplication..")
-        _app = QtWidgets.QApplication([])
+    _app = get_openpype_qt_app()


local variable '_app' is assigned to but never used

hound · 2024-02-21T14:29:00Z

openpype/hosts/aftereffects/plugins/load/load_file.py

            import_options['ImportAsType'] = 'ImportAsType.COMP'
+            comp = stub.import_file_with_dialog(path, stub.LOADED_ICON + comp_name)


line too long (83 > 79 characters)

hound · 2024-02-21T14:29:00Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)
+    bpy.types.WindowManager.render_list_properties = bpy.props.CollectionProperty(type=RenderListProperty)
+    bpy.types.WindowManager.render_layers_to_use = bpy.props.CollectionProperty(type=RenderLayerProperty)


line too long (105 > 79 characters)

hound · 2024-02-21T14:29:00Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)
+    bpy.types.WindowManager.render_list_properties = bpy.props.CollectionProperty(type=RenderListProperty)


line too long (106 > 79 characters)

hound · 2024-02-21T14:29:00Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    bpy.utils.register_class(RenderLayerProperty)
+
+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)


line too long (106 > 79 characters)

hound · 2024-02-21T14:29:00Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+
+def set_render_nodes_output_path():
+    version = paths.get_next_version_folder(bpy.context.scene.render_layer_path)


line too long (80 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+def set_global_output_path():
+    bpy.context.scene.render.filepath = bpy.context.scene.output_path
+    log.info(f"Global output path has been set to '{bpy.context.scene.output_path}'")


line too long (85 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+            setattr(modifier, modifier_attribute, _replace_paths_part(path_to_replace))
+            new_path = getattr(modifier, modifier_attribute, None)
+            log.info(f"Cache file path has been updated from {path_to_replace} to {new_path}")


line too long (94 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+            if not path_to_replace:
+                continue
+
+            setattr(modifier, modifier_attribute, _replace_paths_part(path_to_replace))


line too long (87 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    for cache_file in bpy.data.cache_files:
+        old_path = cache_file.filepath
+        cache_file.filepath = _replace_paths_part(cache_file.filepath)
+        log.info(f"Cache file path has updated from {old_path} to {cache_file.filepath}")


line too long (89 > 79 characters)

hound · 2024-02-21T14:29:00Z

openpype/hosts/aftereffects/api/pipeline.py

-    if not _app:
-        print("Starting new QApplication..")
-        _app = QtWidgets.QApplication([])
+    _app = get_openpype_qt_app()


local variable '_app' is assigned to but never used

hound · 2024-02-21T14:29:01Z

openpype/hosts/aftereffects/plugins/load/load_file.py

            import_options['ImportAsType'] = 'ImportAsType.COMP'
+            comp = stub.import_file_with_dialog(path, stub.LOADED_ICON + comp_name)


line too long (83 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)
+    bpy.types.WindowManager.render_list_properties = bpy.props.CollectionProperty(type=RenderListProperty)
+    bpy.types.WindowManager.render_layers_to_use = bpy.props.CollectionProperty(type=RenderLayerProperty)


line too long (105 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)
+    bpy.types.WindowManager.render_list_properties = bpy.props.CollectionProperty(type=RenderListProperty)


line too long (106 > 79 characters)

hound · 2024-02-21T14:29:01Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    bpy.utils.register_class(RenderLayerProperty)
+
+    bpy.types.WindowManager.scene_filepath = bpy.props.StringProperty('')
+    bpy.types.WindowManager.render_bool_properties = bpy.props.CollectionProperty(type=RenderBoolProperty)


line too long (106 > 79 characters)

hound · 2024-02-21T14:29:02Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+
+def set_render_nodes_output_path():
+    version = paths.get_next_version_folder(bpy.context.scene.render_layer_path)


line too long (80 > 79 characters)

hound · 2024-02-21T14:29:02Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+def set_global_output_path():
+    bpy.context.scene.render.filepath = bpy.context.scene.output_path
+    log.info(f"Global output path has been set to '{bpy.context.scene.output_path}'")


line too long (85 > 79 characters)

hound · 2024-02-21T14:29:03Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+            setattr(modifier, modifier_attribute, _replace_paths_part(path_to_replace))
+            new_path = getattr(modifier, modifier_attribute, None)
+            log.info(f"Cache file path has been updated from {path_to_replace} to {new_path}")


line too long (94 > 79 characters)

hound · 2024-02-21T14:29:04Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+            if not path_to_replace:
+                continue
+
+            setattr(modifier, modifier_attribute, _replace_paths_part(path_to_replace))


line too long (87 > 79 characters)

hound · 2024-02-21T14:29:04Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+    for cache_file in bpy.data.cache_files:
+        old_path = cache_file.filepath
+        cache_file.filepath = _replace_paths_part(cache_file.filepath)
+        log.info(f"Cache file path has updated from {old_path} to {cache_file.filepath}")


line too long (89 > 79 characters)

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

hound · 2024-02-21T14:31:14Z

server_addon/fusion/server/settings.py

+    },
+    "create": {
+        "CreateSaver": {
+            "temp_rendering_path_template": "{workdir}/renders/fusion/{product[name]}/{product[name]}.{frame}.{ext}",


line too long (117 > 79 characters)

hound · 2024-02-21T14:31:14Z

server_addon/deadline/server/settings/publish_plugins.py

+        title="Plugin Limits",
+    )
+
+    @validator("limits_plugin", "env_allowed_keys", "env_search_replace_values")


line too long (80 > 79 characters)

hound · 2024-02-21T14:31:14Z

server_addon/flame/server/settings/loader_plugins.py

+            "review"
+        ],
+        "reel_name": "OP_LoadedReel",
+        "clip_name_template": "{batch}_{folder[name]}_{product[name]}<_{output}>",


line too long (82 > 79 characters)

hound · 2024-02-21T14:31:14Z

server_addon/flame/server/settings/publish_plugins.py

+class CollectTimelineInstancesModel(BaseSettingsModel):
+    _isGroup = True
+
+    xml_preset_attrs_from_comments: list[XMLPresetAttrsFromCommentsModel] = Field(


line too long (82 > 79 characters)

hound · 2024-02-21T14:31:14Z

openpype/hosts/max/api/lib_rendersettings.py

+    from pymxs import runtime as rt
+except ImportError:
+    # Ignoring, we don't want misleading error logs on jobs log on deadline.
+    # Because the farm publish function imports every publish file before filtering.


line too long (84 > 79 characters)

hound · 2024-02-21T14:31:15Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+def update_render_layers_state():
+    for render_layer in bpy.context.window_manager.render_layers_to_use:
+        bpy.context.scene.view_layers[render_layer.name].use = render_layer.value
+        log.info(f"Render layer {render_layer.name} has been set to {render_layer.value}")


line too long (90 > 79 characters)

hound · 2024-02-21T14:31:15Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+def update_render_layers_state():
+    for render_layer in bpy.context.window_manager.render_layers_to_use:
+        bpy.context.scene.view_layers[render_layer.name].use = render_layer.value


line too long (81 > 79 characters)

hound · 2024-02-21T14:31:15Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+        return setattr(rgetattr(obj, pre) if pre else obj, post, val)
+
+
+    def rgetattr(obj, attr, *args):


too many blank lines (2)

hound · 2024-02-21T14:31:16Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+
+    for render_property in bpy.context.window_manager.render_list_properties:
+        set_attribute(render_property.path, render_property.items)
+        log.info(f"attribute {render_property.path} has been set to {render_property.items}")


line too long (93 > 79 characters)

hound · 2024-02-21T14:31:16Z

openpype/hosts/blender/blender_addon/addons/DeadlineBlenderScenePrepare.py

+def set_scene_render_properties():
+    for render_property in bpy.context.window_manager.render_bool_properties:
+        set_attribute(render_property.path, render_property.value)
+        log.info(f"attribute {render_property.path} has been set to {render_property.value}")


line too long (93 > 79 characters)

Thomas Fricard and others added 30 commits November 28, 2023 16:54

create new function to check is there's already an existing workfile …

ceb78e5

…and add it to the condition which start the template build workfile (quadproduction/issues#123)

Include handles

2949558

#214: enhancement: check for deadline addon in bleder_addons folder d…

1dde574

…irectly + enhance browsing node recursive function to handle more cases

Cleanup syntax (quadproduction/issues#123)

98c3425

Move the _autobuild_first_workfile outside of the suspended_refresh a…

f9eed5f

…nd after the set_context_settings (quadproduction/issues#123)

Remove useless import (quadproduction/issues#123)

ecf877c

Merge branch 'bugfix/231-bug-op3169-quad100-maya-doesnt-respect-inclu…

492a1c5

…de-handle-settings' into release/3.16.9-quad-1.1.0

Merge branch 'enhancement/123-auto-generate-first-workfile-base-on-bu…

7a1a7f8

…ild-template-with-workfile' into release/3.16.9-quad-1.1.0

Clear subversion if not present in filename (quadproduction/issues#101)

6ae3a3d

Fix cyclic import

bb2c574

Fix load of publish plugins for the deadline module

cbad9f0

#214: bugfix: also return False when addons folder is not found (whic…

2ae7cee

…h is created when a user script in installed)

#214: bugfix: get current os workdir path for blender default output …

e1f165c

…path

#214: bugfix: remove path to blender libs when setting PYTHONPATH (on…

5bd94fa

…ly keep lib/site-packages)

stop transcoding when review is not checked (quadproduction/issues#164)

1fb7eb6

Merge remote-tracking branch 'origin/enhancement/164-stop-transcode-w…

67ce727

…hen-review-is-unchecked' into release/3.16.9-quad-1.1.0

Add opentimelineio to fix issue in Maya collect plugins

b366570

FIX: commit cbad9f0

24105f1

Fix latest version (quadproduction/issues#101)

fc470b4

Cleanup code (quadproduction/issues#101)

709b2b2

Merge pull request #618 from quadproduction/enhancement/101-fix-version

da7aa9f

Fix latest version (quadproduction/issues#101)

Merge pull request #615 from quadproduction/release/3.16.9-quad-1.1.0

b34d3c7

Release/3.16.9 quad 1.1.0

#214: enhancement: add panel to override properties and launch Deadli…

0e1e535

…ne addon with temporary file as target

#214: enhancement: move output path sets from given script to custom …

ae3f967

…addon

#214: update: change base output path for render nodes and general ou…

849e95e

…tput path

#124: clean: renamed macro button to launch render

7113029

#214: bugfix: format path with slashs instead of antislashes for bett…

3bc8a7a

…er compatibility when replace paths parts

#214: enhancement: auto enable all addons in user custom addons folder

eaf2c5a

Bump version 3.16.9-quad-1.2.0

77e4afe

Houdini: Use the first image as a thumbnail (quadproduction/issues#240)

b184c31

hound bot reviewed Feb 21, 2024

View reviewed changes

ynbot added this to the next-patch milestone Feb 21, 2024

ynbot added module: Sitesync type: documentation type: unittest all involving unittesting module: Shotgrid labels Feb 21, 2024

hound bot reviewed Feb 21, 2024

View reviewed changes

		import_options['ImportAsType'] = 'ImportAsType.COMP'
		comp = stub.import_file_with_dialog(path, stub.LOADED_ICON + comp_name)



		def set_render_nodes_output_path():
		version = paths.get_next_version_folder(bpy.context.scene.render_layer_path)

		return setattr(rgetattr(obj, pre) if pre else obj, post, val)


		def rgetattr(obj, attr, *args):

Release/3.16.9 quad 1.8.2 #6229

Release/3.16.9 quad 1.8.2 #6229

Conversation

BenSouchet commented Feb 21, 2024 • edited Loading

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

hound bot Feb 21, 2024

Choose a reason for hiding this comment

BenSouchet commented Feb 21, 2024 •

edited

Loading