Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Tests: Fix failing maya automatic test #6231

Closed
wants to merge 2 commits into from
Closed

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Feb 22, 2024

Changelog Description

Caused by tripping on failed import of Max submit to deadline, because of Max library, issue of Pyblish imports handling. That file shouldn't be imported at all in perfect world.

Additional info

Was causing # Error: pyblish.plugin : Skipped: "submit_max_deadline" (No module named 'pymxs') # error

This is a bit band aid fix, but everything else would be much more elaborate.

Testing notes:

  1. run C:\test_build\tests\integration\hosts\maya\test_publish_in_maya.py

Caused by tripping on failed import of Max submit to deadline, because of Max library, issue of Pyblish imports handling. That file shouldn't be imported at all in perfect world.
@kalisp kalisp added the type: unittest all involving unittesting label Feb 22, 2024
@kalisp kalisp requested a review from tokejepsen February 22, 2024 11:04
@ynbot ynbot added host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files and removed type: unittest all involving unittesting labels Feb 22, 2024
Copy link
Member

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be fixed in the host integration, similar to #5954

@kalisp
Copy link
Member Author

kalisp commented Feb 23, 2024

I tried that, but couldn't figure all places I need to move imports around.

@tokejepsen
Copy link
Member

How about we just focus on this plugin and these imports?

https://github.com/ynput/OpenPype/blob/develop/openpype/modules/deadline/plugins/publish/submit_max_deadline.py#L19-L26

Its the Deadline modules' plugins folder that is the culprit of all these import issues. Ideally that plugins folder should have a folder per host or register individual plugins rather than the whole folder.

@tokejepsen tokejepsen closed this Feb 26, 2024
@ynbot ynbot added this to the next-patch milestone Feb 26, 2024
@tokejepsen tokejepsen deleted the chore/fix_maya_test branch March 5, 2024 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants