Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

tokejepsen
Copy link
Member

Changelog Description

Due to frameStart data member on representation for existing frames, the frame indexes would be re-numbered when integrating due to this; https://github.com/ynput/OpenPype/blob/develop/openpype/plugins/publish/integrate.py#L712-L726

Removing frameStart had no effect on publishing workflows, local or farm.

Also fixed an issues with slate collection which could misbehave if the instance node had "slate" in the name.

Resolves #5883

Testing notes:

  1. Add nuke slate to the script
  2. Publish render using local machine rendering
  3. Publish render with Use existing frames option (will reuse render from previous step)
  4. Check integration logs where it copied files to publish destination, which should keep frame indexes intact. Looks like this:
Copying file ... P:\PROJECTS\toke_testing\OP_7336_slate_workflow_broken_if_existing_frames\work\compositing\renders\nuke\renderCompositingSlate\renderCompositingSlate.0000.exr -> P:\PROJECTS\toke_testing\OP_7336_slate_workflow_broken_if_existing_frames\publish\render\renderCompositingSlate\v031\toke_testing_OP_7336_slate_workflow_broken_if_existing_frames_renderCompositingSlate_v031.0000.exr

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Mar 7, 2024
@tokejepsen tokejepsen requested a review from jakubjezek001 March 7, 2024 21:19
@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Nuke type: bug Something isn't working labels Mar 7, 2024
@jakubjezek001 jakubjezek001 requested a review from jrsndl March 8, 2024 08:37
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked like a charm ;) Tested on local render, existed frames and exited on farm. All had the same results. Thanks!

@jakubjezek001 jakubjezek001 merged commit 9a4312f into develop Mar 8, 2024
13 checks passed
@jakubjezek001 jakubjezek001 removed the sponsored Client endorsed or requested label Mar 8, 2024
@ynbot ynbot added this to the next-patch milestone Mar 8, 2024
@jakubjezek001 jakubjezek001 added the sponsored Client endorsed or requested label Mar 8, 2024
@tokejepsen tokejepsen deleted the bugfix/AY-1433_Nuke-Render-Use-existing-frames-with-slate-offsets-the-published-render branch March 8, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Nuke Render "Use existing frames" with slate offsets the published render.
3 participants