This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Local/aroma integrate 3de4 #6247
Closed
+270,112
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equalizer-integration
…equalizer-integration
…equalizer-integration
…gration' into feature/OP-6032_3dequalizer-integration
…equalizer-integration
ynbot
added
the
size/XXL
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| else: | ||
| overscan_width, overscan_height = 100, 100 | ||
| # raise PublishValidationError("You must extract the undistorted footage first to get the overscan") | ||
|
|
| overscan_width, overscan_height = overscan.values() | ||
| else: | ||
| overscan_width, overscan_height = 100, 100 | ||
| # raise PublishValidationError("You must extract the undistorted footage first to get the overscan") |
There was a problem hiding this comment.
line too long (112 > 79 characters)
trailing whitespace
| ) | ||
| from openpype.pipeline import PublishValidationError | ||
|
|
||
| @six.add_metaclass(ABCMeta) |
| Creator, | ||
| OptionalPyblishPluginMixin, | ||
| ) | ||
| from openpype.pipeline import PublishValidationError |
There was a problem hiding this comment.
'openpype.pipeline.PublishValidationError' imported but unused
|
|
||
| # TODO EDITED | ||
| # change_anim = QtCore.QVariantAnimation() | ||
| class VariantAnimation(QtCore.QVariantAnimation): |
There was a problem hiding this comment.
expected 1 blank line before a nested definition, found 0
| return current_filepath | ||
|
|
||
|
|
||
| def get_overscan(self): |
| def open_workfile(self, filepath): | ||
| result = tde4.loadProject(filepath) | ||
| if not bool(result): | ||
| raise RuntimeError("Failed to open workfile %s."%filepath) |
There was a problem hiding this comment.
missing whitespace around modulo operator
| def save_workfile(self, filepath=None): | ||
| result = tde4.saveProject(filepath) | ||
| if not bool(result): | ||
| raise RuntimeError("Failed to save workfile %s."%filepath) |
There was a problem hiding this comment.
missing whitespace around modulo operator
| import contextlib | ||
| import tde4 | ||
|
|
||
| @attr.s |
| # | ||
| # TODO Replacement for the above code. | ||
| QtCore.QObject.connect(plugins_view.selectionModel(), | ||
| QtCore.SIGNAL('selectionChanged(QItemSelection,QItemSelection)'), self._on_plugin_change) |
| # ) | ||
| # TODO Replacement for the above code. | ||
| QtCore.QObject.connect(instances_view.selectionModel(), | ||
| QtCore.SIGNAL('selectionChanged(QItemSelection,QItemSelection)'), self._on_instance_change) |
|
|
||
| # TODO Replacement of the above code | ||
| QtCore.QObject.connect(instance_view.selectionModel(), | ||
| QtCore.SIGNAL('selectionChanged(QItemSelection,QItemSelection)'), self._on_selection_change) |
| icon = "glasses" | ||
|
|
||
| def create(self, subset_name, instance_data, pre_create_data): | ||
| super(CreateLensDistortionData, self).create(subset_name, instance_data, pre_create_data) |
|
|
||
| def create(self, subset_name, instance_data, pre_create_data): | ||
| self.log.debug("CreateMatchMove.create") | ||
| super(CreateMatchMove, self).create(subset_name, instance_data, pre_create_data) |
| @@ -0,0 +1,57 @@ | |||
| import tde4 | |||
| tde4.setLensFocalLength(lens_id, float(camera_focal[0])) | ||
|
|
||
|
|
||
| def update(self, container, representation): |
| if 'camera_focal' in metadata_attrs: | ||
| camera_focal = metadata_attrs['camera_focal'].split() | ||
| if camera_focal[1] == 'mm': | ||
| tde4.setLensFocalLength(lens_id, float(camera_focal[0])/10) |
There was a problem hiding this comment.
missing whitespace around arithmetic operator
| for a in root.findall("attribute"): | ||
| name = a.find("name").text | ||
| value = a.find("value").text | ||
| if name and value: metadata_attrs[name] = value |
There was a problem hiding this comment.
multiple statements on one line (colon)
| frame_path = tde4.getCameraFrameFilepath(camera_id, frame) | ||
| try: | ||
| xml = tde4.convertOpenEXRMetaDataToXML(frame_path) | ||
| except: |
There was a problem hiding this comment.
Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.
do not use bare 'except'
| EqualizerHost.get_host().add_container(container) | ||
|
|
||
|
|
||
| def _assignMetaData(self, camera_id, lens_id): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Paragraphs contain detailed information on the changes made to the product or service, providing an in-depth description of the updates and enhancements. They can be used to explain the reasoning behind the changes, or to highlight the importance of the new features. Paragraphs can often include links to further information or support documentation.
Additional info
Paragraphs of text giving context of additional technical information or code examples.
Testing notes: