Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

[QUAD] Enhancement: Reactivating ftrack user while he has active deadline jobs #6298

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ccaillot
Copy link

No description provided.

},
{
"type": "label",
"value": "The following jobs from this user are currently active "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (82 > 79 characters)

# Re-activate the account
user['is_active'] = True
session.commit()
self.log.info("the user {} has been re-activated".format(user['username']))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (83 > 79 characters)

return
if "isactive" not in entity_info.get('changes', {}):
return
if entity_info['changes']['isactive'].get('new') != False:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparison to False should be 'if cond is not False:' or 'if cond:'

class KeepUserActiveForDeadline(BaseEvent):

def launch(self, session, event):
"""Ensure the user stays active while having ongoing job(s) in the Deadline."""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (87 > 79 characters)

@@ -0,0 +1,98 @@
import ftrack_api
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ftrack_api' imported but unused

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files module: Deadline AWS Deadline related features module: Ftrack labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Deadline AWS Deadline related features module: Ftrack size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

2 participants