-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unrealuasset as the publish template #328
Add unrealuasset as the publish template #328
Conversation
@antirotor @iLLiCiTiT guys, who is the best for review of this one? |
Let me share my 2 cents.. |
I also wonder why anatomy settings live in ayon-backend repo. Tagging @dee-ynput |
That's actually a very legit question for which I would love to have the answer :) |
I don't know what do you mean. That core addon would somehow define the anatomy model? Or its part? Please elaborate how it would work. Keep in mind that across the system we heavily depend on certain parts of the anatomy, such as statuses, folder/task types and roots. |
tbh, It's hard for me to make a suggestion in this area. But, I didn't expect that a PR to Personally, I thought that |
This PR just adds a one item to defaults of the built-in anatomy preset. It might as well be an example. As soon a studio creates their own anatomy preset, they may delete this one. Maybe we could replace the default_factory method of publish templates with something else (pulling from an addon?). but is it worthed? the entire idea behind anatomy presets is that studio can create one or more custom preset they will use. |
We can mention in the documentation about this anatomy preset and how they can use it for the uasset publish. If the users get any question on the uasset publish, we can just guide them to the docs and ask them to add the anatomy preset and its relevant setting in the core addon. |
So, instead of this PR, we will add something like the following in Docs: I think this could work. But, I'm not sure what is better product wise.
maybe, I can't tell. -- tbh, I just didn't know that anatomy definitions are part of the backend itself. which sounds strange to me as I thought that is living in the core addon. which also not entirely correct idea because AYON server can have no addons and then we should have the anatomy definitions to be able to create any projects. anyways, I should leave it for some who is smarter and have wider overview than me. |
The anatomy is a core concept of AYON, naming convention (template) is more or less a core concept, but DCC specific templates should definitely not be declared at server core. That being said,:
So I would validate this PR and fix that concern (+more) later with a dedicated Epic 👍 |
PR Checklist
Description of changes
Added the published template setting for unreal uasset/umap publishing
Related to this PR: ynput/ayon-core#859
Technical details
The current uasset/umap publisher is using default template name as the published path, but the default one would change the filename of the uasset/umap, which would corrupt the uasset/umap, and u sers cannot load the uasset/umap. There is some custom publish template needs to be added to make sure the uasset is published with original filename so that the file itself would not be corrupted.
Additional context
The related ayon-core PR: ynput/ayon-core#859
The related issues: ynput/ayon-unreal#64 and ynput/ayon-unreal#66