Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/AY-6116-blender_allow_handles_frame_range #28

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

jrsndl
Copy link

@jrsndl jrsndl commented Sep 5, 2024

Changelog Description

Allows to configure in settings whether a workfile frame range should include the handles or not for certain tasks. The default is like before where handles are excluded from the timeline.

Additional info

Should address the issue #27

Matches a similar feature in ayon-maya.

Testing notes:

  1. Upload new addon
  2. Tweak the settings for Including handles or not
  3. Trigger set frame range

@jrsndl jrsndl marked this pull request as ready for review September 5, 2024 14:39
…develop_jrsndl

# Conflicts:
#	client/ayon_blender/api/pipeline.py
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Sep 5, 2024
@BigRoy BigRoy self-assigned this Sep 5, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Sep 5, 2024

Resolved the conflicts, pushed some cosmetic fixes and updated the PR description and added reviewers. Happy testing @LiborBatek 🫶

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I enable the include_handles_default, the setting works as expected. But setting up the handle does not work when the task type being enabled,

When the include_handles_default settings is disabled, and with the tasktype filtering system set up, all the handles in all task types are not set up by clicking the set frame range.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been tested in both settings with handles used and when disabled and not used...

image

Works like charm!

@BigRoy
Copy link
Contributor

BigRoy commented Sep 6, 2024

@LiborBatek how about the case that Kayla mentioned:

When I enable the include_handles_default, the setting works as expected. But setting up the handle does not work when the task type being enabled,

When the include_handles_default settings is disabled, and with the tasktype filtering system set up, all the handles in all task types are not set up by clicking the set frame range.

It sounds like @moonyuet says the task type filtering does not work as intended, or?

Should be fixed with 0d7d2e5

@BigRoy
Copy link
Contributor

BigRoy commented Sep 6, 2024

I had a look at the Maya implementation here and I think I fixed it with 0d7d2e5 @moonyuet could you confirm?

@BigRoy BigRoy requested a review from moonyuet September 6, 2024 08:50
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I have made test before the Task Profiles and it was working fine as Kayla mentioned...

but when Profiles used it does not take handles into account, need to be addressed

@LiborBatek LiborBatek self-requested a review September 6, 2024 13:47
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-test it again and it works well now!
thanks goes to @iLLiCiTiT pushing (me) to redo it

@BigRoy BigRoy merged commit 1cb221b into ynput:develop Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants