-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement/AY-6116-blender_allow_handles_frame_range #28
Conversation
…develop_jrsndl # Conflicts: # client/ayon_blender/api/pipeline.py
Resolved the conflicts, pushed some cosmetic fixes and updated the PR description and added reviewers. Happy testing @LiborBatek 🫶 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I enable the include_handles_default
, the setting works as expected. But setting up the handle does not work when the task type being enabled,
When the include_handles_default
settings is disabled, and with the tasktype filtering system set up, all the handles in all task types are not set up by clicking the set frame range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LiborBatek how about the case that Kayla mentioned:
It sounds like @moonyuet says the task type filtering does not work as intended, or? Should be fixed with 0d7d2e5 |
I had a look at the Maya implementation here and I think I fixed it with 0d7d2e5 @moonyuet could you confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I have made test before the Task Profiles
and it was working fine as Kayla mentioned...
but when Profiles
used it does not take handles into account, need to be addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-test it again and it works well now!
thanks goes to @iLLiCiTiT pushing (me) to redo it
Changelog Description
Allows to configure in settings whether a workfile frame range should include the handles or not for certain tasks. The default is like before where handles are excluded from the timeline.
Additional info
Should address the issue #27
Matches a similar feature in
ayon-maya
.Testing notes: