Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7222 Fix otio_review no handles and tempdir for Resolve #1041

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

Resolve ynput/ayon-resolve#44

  • Ensure ayon-core.pipeline.tempdir.create_custom_tempdir is still exposed but flagged as backward compatible.
    This function is not officially exposed in the __init__.py but directly called from within resolve:
    https://github.com/search?q=org%3Aynput+create_custom_tempdir&type=code

  • Ensure extract OTIO review does not expect handle values when no otioClip is set

Testing notes:

Testing procedure through Resolve is here: ynput/ayon-resolve#46

@robin-ynput robin-ynput self-assigned this Dec 9, 2024
@ynbot
Copy link
Contributor

ynbot commented Dec 9, 2024

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small optional comment, otherwise looks good.

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one incomatibility.

@robin-ynput
Copy link
Contributor Author

Noticed one incomatibility.

This is adjusted ! Cheers.

@robin-ynput robin-ynput merged commit 30dcf53 into develop Dec 11, 2024
3 checks passed
@robin-ynput robin-ynput deleted the bugfix/AY_7222-fix_create_custom_dir branch December 11, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Resolve size/XS sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AY-7222_Set Editorial pkg media to be reviewable
4 participants