Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AY-7222 Make editorial package reviewable #46

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

AY-7222 Make editorial package reviewable #46

wants to merge 2 commits into from

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Dec 9, 2024 •
edited
Loading

Changelog Description

resolve #44
Make the editorial pckg intermediate media reviewable.

This PR needs to be tested alongside: ynput/ayon-core#1041

Testing notes:

  1. Ensure some reviewable setup is configured for Resolve
    image
  2. Open a timeline in Resolve and publish an editorial package from it
  3. Ensure the intermediate media is properly processed as a reviewable
    image

@ynbot
Copy link
Contributor

ynbot commented Dec 9, 2024

Task linked: AY-7222 Set Editorial pkg media to be reviewable

@robin-ynput robin-ynput self-assigned this Dec 9, 2024
@robin-ynput robin-ynput added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Dec 9, 2024
@robin-ynput robin-ynput mentioned this pull request Dec 9, 2024
Merged
@robin-ynput robin-ynput marked this pull request as ready for review December 10, 2024 00:01
@jakubjezek001
Copy link
Member

Looking good @robin-ynput - Lets enhance it even more please and add Review toggle into instance attributes and make it optional.

@robin-ynput
Copy link
Contributor Author

robin-ynput commented Dec 10, 2024 •
edited
Loading

Looking good @robin-ynput - Lets enhance it even more please and add Review toggle into instance attributes and make it optional.

will do !
Done
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@BigRoy BigRoy Awaiting requested review from BigRoy

At least 1 approving review is required to merge this pull request.

Assignees

@robin-ynput robin-ynput

Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-7222_Set Editorial pkg media to be reviewable
3 participants
@robin-ynput @ynbot @jakubjezek001