Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio extraction from OTIO timeline. #1026

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

This resolves ynput/ayon-hiero#32

The audio extraction code hasn't been updated since the recent work to fix embedded timecode detection and media available range computation. These changes ensure that OTIO audio extraction properly works for updated and non-updated OTIO exporters.

Testing notes:

  1. Prepare a timeline in Hiero with audio tracks
  2. Ideally you'll want to use medias with embedded timecodes
  3. Publish audio clip(s) from this timeline
  4. Ensure that resulting audio products match the different clip(s) from the timeline

@robin-ynput robin-ynput self-assigned this Nov 25, 2024
@ynbot ynbot added size/XS type: bug Something isn't working labels Nov 25, 2024
@robin-ynput robin-ynput marked this pull request as ready for review November 25, 2024 21:14
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it but changes do make sense.

@robin-ynput robin-ynput merged commit 82d3948 into develop Nov 26, 2024
1 check passed
@robin-ynput robin-ynput deleted the bugfix/fix_extract_otio_audio branch November 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Resolve type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate potential audio mismatch with new OTIO frame range computation
3 participants