Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farm env: Collect correct values for farm #1031

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Actually collect valid values for farm environment variables.

Additional info

The plugin did use values from os.environ but most of the values are not set in env variables, or it should not be based on env variables.

  • AYON_USERNAME - is not filled in os.environ
  • AYON project/folder/task - should be filled from context data instead of os.environ
  • AYON_LOG_NO_COLORS - should be forced to be "1" for farm

Testing notes:

  1. The values under farm key are correct.

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 29, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 29, 2024
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy November 29, 2024 10:01
@ynbot ynbot added the size/XS label Nov 29, 2024
@iLLiCiTiT iLLiCiTiT requested a review from kalisp November 29, 2024 10:01
@iLLiCiTiT iLLiCiTiT merged commit 01a5917 into develop Nov 29, 2024
12 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/better-value-sources-for-farm-env branch November 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants