Push to library project: Error UX improvements #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
added
type: bug
ynbot
added
type: enhancement
|
Not sure if I test it correctly, only this appears... |
|
I would say yes. It is the same error as here #1035 , but without the traceback. |
64qam
approved these changes
Dec 11, 2024
iLLiCiTiT
deleted the
enhancement/1035-renders-push-to-library-project-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Capture
TaskNotSetErrorto raise artist friendly message. Any unhandled exception will show generic message and button to show error detail dialog.Additional info
Button
Try againis visible all the time if it fails. Buttons now have some tooltips. Text in overlay label can be selected to be copied.Testing notes:
"Unhandled error happened. Check error detail for more information."and button to see full traceback. (I don't know how to trigger unhandled error...).Resolves #1035