Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Houdini Karma/Mantra collectors wrong indentation #206

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 19, 2024

Changelog Description

Fix indendations

Additional info

These would've broken in the case the "chunkSize" parm did not exist because render_products and files_by_aov would have been undefined variables.

Testing notes:

  1. Publish Karma ROP instance
  2. Publish Mantra ROP instance

(Also test instances without the chunkSize parm, likely from older legacy instances - but maybe best to reproduce by removing the parms manually?)

@BigRoy BigRoy requested a review from MustafaJafar March 19, 2024 23:38
@ynbot ynbot added type: bug Something isn't working size/S labels Mar 19, 2024
@BigRoy BigRoy requested a review from moonyuet March 19, 2024 23:38
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far.
I tested the following variations for both Mantra and Karma:

  1. Use smaller value than my scene frame range .. (cool, separated in tasks)
  2. Use bigger value than my scene frame range .. (cool, appeared as one task)
  3. Remove chunk size from nodes .. (cool too.)

I have some thought.. Let me think out loud.
[Not Related to this PR, I guess.]
The life cycle of fetching chunk size is:

  1. collect_karma_rop.py.. (read chunkSize from node, save it in instance.data)
  2. submit_houdini_render_deadline.py .. (which adds attribute defs in publisher UI)
    i. in get_attribute_defs default of cls.chunk_size is fetched from class attributes that can be overridden by ayon houdini deadline settings.
    ii. set job_info.ChunkSize to self.chunk_size

That life cycle made me question: Is chunk_size parm being ignored ?
I checked abstract_submit_deadline.py but I found chunkSize has a hard coded default.
While I'm not sure about it because I might have skipped something.
But, this test is some how confirm my concern.
image

Also, Another question which default value should chunkSize fall to ?
e.g. chunkSize parm in Houdini node or chunkSize in Ayon Houdini deadline settings ?

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 25, 2024
@mkolar
Copy link
Member

mkolar commented Mar 27, 2024

Looking good and ready to merge. I'd say we can change the chunksize default in a different PR

@mkolar mkolar merged commit 88cb5ee into ynput:develop Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Houdini size/S type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants