Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Allow loading any alembic file by .abc extension #227

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 24, 2024

Changelog Description

Allow loading any alembic file by .abc extension, regardless of representation name

Additional info

I'm not entirely sure anymore why we needed this in OpenPype and what family of {"model", "animation", "pointcache", "gpuCache"} actually exported to a different representation name than abc. Anyway it shouldn't change existing behavior and the change does make sense as to "on what" it should show.

I wonder if we should remove the product types filter as well.

Testing notes:

  1. Load an Alembic in Houdini should work (also as 'archive')

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Houdini size/XS labels Mar 24, 2024
@MustafaJafar MustafaJafar self-requested a review March 25, 2024 10:51
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 25, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

I'm not entirely sure anymore why we needed this in OpenPype and what family of {"model", "animation", "pointcache", "gpuCache"} actually exported to a different representation name than abc.

I think it might have been added for future considerations.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pointcache can also produce bgeo

@antirotor antirotor merged commit 816155a into ynput:develop Mar 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Houdini size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants