Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Alembic Load do not create unpack, normal and null #274

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 27, 2024

Changelog Description

On Alembic loading to SOPs do not automatically create unpack, normal and null

Additional info

Fixes #253 based on comments by @fabiaserra

Also removed the assignment to self[:] since it's unused.

Testing notes:

  1. Loading and managing loaded Alembics should work
  2. Managing "legacy" loaded containers should also work
    • They will still have the unpack, normal and null - only newly loaded containers will not.

@ynbot ynbot added size/XS host: Houdini type: enhancement Improvement of existing functionality or minor addition labels Mar 27, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 27, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side.
I wonder if we should add output node or null node at the end.
I think it can save sometime for artists.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 27, 2024

It works on my side.
I wonder if we should add output node or null node at the end.
I think it can save sometime for artists.

I wouldn't do that. We want to provide the minimal. It being the only node inside of it - it's already the "output" and we're also not doing this for e.g. the bgeo loader or other SOPs loaders as far as I know.

Wonder what @fabiaserra thinks?

@fabiaserra
Copy link
Contributor

fabiaserra commented Mar 27, 2024

It works on my side.
I wonder if we should add output node or null node at the end.
I think it can save sometime for artists.

I wouldn't do that. We want to provide the minimal. It being the only node inside of it - it's already the "output" and we're also not doing this for e.g. the bgeo loader or other SOPs loaders as far as I know.

Wonder what @fabiaserra thinks?

Yeah I don't think it's necessary, although it would be good to add support to switch to the context where it gets loaded with the new node selected so it's clear to the artist that something was loaded

@BigRoy
Copy link
Collaborator Author

BigRoy commented Mar 27, 2024

Yeah I don't think it's necessary, although it would be good to add support to switch to the context where it gets loaded with the new node selected so it's clear to the artist that something was loaded

Ah yes, I think that's a different beast to tackle since currently it loads into the avalon container which (at least for us) isn't a workspace one usually works in, but usually gets object merged.

Anyway, definitely different issue.

@antirotor antirotor merged commit c663a32 into ynput:develop Apr 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Houdini size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Houdini: Load Alembic - disable automatic unpacking
6 participants