-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Formatting fixes #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
Improvement of existing functionality or minor addition
host: 3dsmax
host: Harmony
host: Houdini
host: Maya
host: UE
module: Deadline
size/S
labels
Mar 27, 2024
kalisp
reviewed
Mar 27, 2024
client/ayon_core/hosts/hiero/api/startup/Python/StartupUI/otioimporter/OTIOImport.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Petr Kalis <[email protected]>
kalisp
reviewed
Mar 27, 2024
BigRoy
reviewed
Mar 27, 2024
BigRoy
reviewed
Mar 27, 2024
kalisp
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually it look ok.
BigRoy
reviewed
Mar 27, 2024
client/ayon_core/hosts/hiero/api/startup/Python/StartupUI/otioimporter/OTIOImport.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Mar 27, 2024
client/ayon_core/hosts/hiero/plugins/publish_old_workflow/precollect_retime.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Mar 27, 2024
BigRoy
reviewed
Mar 27, 2024
client/ayon_core/hosts/maya/plugins/publish/extract_unreal_skeletalmesh_fbx.py
Show resolved
Hide resolved
Co-authored-by: Roy Nieterau <[email protected]>
Co-authored-by: Roy Nieterau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
host: Houdini
host: Maya
host: UE
host: 3dsmax
module: Deadline
size/S
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Small enhancements of code formatting.
Additional info
Removed unused variables. Removed unnecessary f-strings, removed
format
when there is nothing to format, fixed some formattings which used combination of{}
and%s
for formatting. Fixed one Python 2 exception capture (except Exception, e
>except Exception as e
). Useisinstance
for type check. Converted lambda to real function.NOTE: Based on PR #196 .