Max: Using task attributes for validate frame range and validate resolution setting

[moonyuet]

Changelog Description

Align to use the data from task entity in regard to other hosts

Additional info

n/a

Testing notes:

1. Launch Max
2. Create Render Instance/Review Instance
3. Publish

[LiborBatek]

Has been tested in max 2024 and works ok for render instance

validates well against frame range set in the database for current folder

and also for Resolution

My only concern is when using Review instance it does not validate against resolution and just ignores it...it seems that for this instance type we do not validate for resolution...I think we should include an optional settings for that too (as on render instance type)

[moonyuet]

Has been tested in max 2024 and works ok for render instance

validates well against frame range set in the database for current folder

and also for `Resolution`

My only concern is when using Review instance it does not validate against resolution and just ignores it...it seems that for this instance type we do not validate for resolution...I think we should include an optional settings for that too (as on render instance type)

It is supposed that it should be at the separate PR but since this PR is quite small, I guess I can also implement here as it is adding back review as product type

[LiborBatek]

The Resolution Validator does work for Render instance but not for Review instance.

Also the Repair action only fixes the Render Settings aka Render Resolution but not changing the Review instance resolution.

When fixed the Render instance resolution it Validates OK even if the Review instance still having wrong set resolution.

not sure if related but here is copy paste from Max listener aka console:

  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_resolution_setting.py", line 31, in process
    raise PublishValidationError("Resolution Setting "
ayon_core.pipeline.publish.publish_plugins.PublishValidationError: Resolution Setting not matching resolution set on asset or shot.
>>> [ *** Discovered 1 abstract plugins

Now Review having Validate Resolution which is fine and desired...

[moonyuet]

The Resolution Validator does work for Render instance but not for Review instance.

Also the Repair action only fixes the Render Settings aka Render Resolution but not changing the Review instance resolution.

When fixed the Render instance resolution it Validates OK even if the Review instance still having wrong set resolution.

not sure if related but here is copy paste from Max listener aka console:

  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_resolution_setting.py", line 31, in process
    raise PublishValidationError("Resolution Setting "
ayon_core.pipeline.publish.publish_plugins.PublishValidationError: Resolution Setting not matching resolution set on asset or shot.
>>> [ *** Discovered 1 abstract plugins

Now Review having Validate Resolution which is fine and desired...

I have separated validator for resolution setting in terms of render and review product type, as they dont get resolution data for exporting the sequences in a similar method. Can you test it again? @LiborBatek thanks!

[iLLiCiTiT]

@moonyuet please update with latest develop. @LiborBatek please test again.

[LiborBatek]

I did new test round and found that

Validate Frame Range works and also Repair action too

but for Validate Resolution besides validation itself which works ok, the Repair action can fix global render settings namely for Render instance types but when using this validator on Review instance then the repair fails on instance.

and after triggered Repair action resolution still the same / invalid on the publish Review Instance...

[LiborBatek]

Now all Validators for resolution and frame ranges working with Repair actions for both Render and Review instances. All good

Only minor thing, there is unneccessarily long name for validator of the review resolution as seen on scrngrab here

Should be imho just Validate Resolution or Validate Review Resolution.
Other than that good and can be merged then...

[moonyuet]

I already renamed in the updated commit.

[BigRoy]

Now all Validators for resolution and frame ranges working with Repair actions for both Render and Review instances. All good

Only minor thing, there is unneccessarily long name for validator of the review resolution as seen on scrngrab here

Should be imho just Validate Resolution or Validate Review Resolution. Other than that good and can be merged then...

Just for context:

• In maya it is Validate Resolution.
• It's Validate Folder Resolution in Fusion.
• There is Validate Write Resolution in Nuke but I believe that's slightly different validation.
• In After Effects it's part of a larger Validate Scene Settings validator. Similar to TVPaint.