Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AYON_MENU_LABEL #5

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 7, 2024

Changelog Description

Replace usage of AVALON_LABEL with AYON_MENU_LABEL.

Additional info

The most changes happened in nuke where variables into which was value stored did contain AVALON_ and was duplicated multiple times. Variables in nuke were reduced _NODE_TAB_NAME renamed to NODE_TAB_NAME, AVALON_LABEL renamed to MENU_LABEL, AVALON_TAB replaced by NODE_TAB_NAME, AVALON_DATA_GROUP renamed to DATA_GROUP_KEY.

Testing notes:

  1. All labels should work as before and show correct label AYON.
  • Blender
  • Maya
  • Max
  • Houdini
  • Harmony
  • SubstancePainter
  • Nuke
  • Hiero
  • Fusion
  • Resolve
  • AE
  • TvPaint

@simonebarbieri
Copy link
Contributor

Blender works fine!

@iLLiCiTiT iLLiCiTiT removed the request for review from LiborBatek February 8, 2024 10:39
@moonyuet
Copy link
Member

moonyuet commented Feb 8, 2024

Tested in Maya, Max, Nuke and Substance Painter. All work fine.

@mkolar
Copy link
Member

mkolar commented Feb 8, 2024

Don't see a reason why this wouldn't work across the board. I'd merge it

@iLLiCiTiT iLLiCiTiT merged commit 2746bc9 into feature/OP-8123_Addon-initialization-phase-one Feb 8, 2024
2 of 5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/use-ayon-menu-label branch February 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants