-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max: Implementation of the validator for model name #59
Conversation
Im getting this error when validating the publish:
|
This happens mainly because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/ayon_core/hosts/max/plugins/publish/validate_model_name.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it more artist friendly, especially validator that will trigger probably very often. I know that we are not using it on many places, but publisher has already ability to show stuff.
Maybe not the greatest example, but it is using PublishXmlValidationError
and xml file located in help directory.
I do understand that this is pretty straightforward validation that is requiring simple action from artist, so I stating it here mainly as a reference.
client/ayon_core/hosts/max/plugins/publish/validate_model_name.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/max/plugins/publish/validate_model_name.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart that json file it looks a works great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't probably be here in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks for the changes!
Changelog Description
Ported from Openpype: ynput/OpenPype#6164
Implement the validator for model name in 3dsmax
Additional info
The validation regex by default is
(.*)_(?P<subset>.*)_(GEO)
andyour model name should be {Some name}_{SubsetName}_GEO
Testing notes: