Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Houdini: Publish different HDA products from different folder paths with the same product name #644

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Houdini: Publish different HDA products from different folder paths with the same product name #644

merged 6 commits into from
Jun 14, 2024

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Fix a bug when publishing different HDA products from different folder paths with the same product name.

image

Additional info

About the bug: product name was being used for HDA type name and type label.
when publishing HDA from different folder paths with the product name results in having multiple HDAs/Houdini nodes with the
type name. which makes houdini thinks they are the same HDA.

Testing notes:

  1. Publish HDAs from different folder paths, maybe different projects too.
  2. Load the published HDAs.

@MustafaJafar MustafaJafar added host: Houdini backlog added into backlog sponsored This is directly sponsored by a client or community member labels Jun 12, 2024
@ynbot
Copy link
Contributor

ynbot commented Jun 12, 2024

Task linked: AY-5777 Publish different HDA products from different folder paths with the same product name

@MustafaJafar MustafaJafar linked an issue Jun 12, 2024 that may be closed by this pull request
Houdini: Publish different HDA products from different folder paths with the same product name #534
Closed
2 tasks
@ynbot ynbot added size/XS type: bug Something isn't working labels Jun 12, 2024
@MustafaJafar MustafaJafar requested a review from BigRoy June 12, 2024 15:37
moonyuet
moonyuet approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Houdini with published hda and loader. The loaded HDAs showed the names with different folder path and same product name if they are published with different folder paths.

antirotor
antirotor requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart the exception, it looks good and it works

@MustafaJafar MustafaJafar requested a review from antirotor June 13, 2024 16:40
@antirotor antirotor merged commit 8e96c86 into develop Jun 14, 2024
1 check passed
@antirotor antirotor deleted the bugfix/AY-5777_HDA-products-different-folder-paths-same-product-name branch June 14, 2024 10:02
@MustafaJafar MustafaJafar mentioned this pull request Jun 14, 2024
Merged
5 tasks
@BigRoy BigRoy mentioned this pull request Jun 25, 2024
Closed
2 tasks
@BigRoy BigRoy mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antirotor antirotor antirotor approved these changes

@moonyuet moonyuet moonyuet approved these changes

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

@BigRoy BigRoy Awaiting requested review from BigRoy

Assignees
No one assigned
Labels
backlog added into backlog host: Houdini size/XS sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Houdini: Publish different HDA products from different folder paths with the same product name
5 participants
@MustafaJafar @ynbot @BigRoy @antirotor @moonyuet