Houdini: Fix single frame publishes #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
The
instance.data["frames"]in the CollectFrames plug-in stores astrif it's a single frame but alistif it's multiple files, similar to how the Integrator currently likes it.However, there was some scattered logic that seemed to assume that
instance.data["frames"]was always aList[str]which isn't expected anymore now.Additional info
Fixes #672
I feel like it'd still be worth it to start moving into logic where there's a single
ExtractROPplug-in that works the same for all ROP nodes because the shared logic across them is 99% the same, and where it currently isn't it should become the same. So I may follow up with another PR after this to start working to a single ExtractROP plug-in.Testing notes: