-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Houdini Mantra IFD local submission #75
Conversation
Note: Thus, I've enabled |
maybe we can just add an optional validator to check for the temp to avoid the error with the temp file storage. |
I tested with houdini, all functions work. |
client/ayon_core/hosts/houdini/plugins/create/create_mantra_ifd.py
Outdated
Show resolved
Hide resolved
# Enable `Save Geometery Inline` | ||
# As it's hard to update the geo reference | ||
# inside the IFD file after publishing the IFDs. | ||
"vm_inlinestorage": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Containing all the geometry into the output file means you're basically bloating the filepath a lot. I really feel like this is the opposite of what a 'render' file should look like - it should be a lightweight file whenever possible.
I understand the comment as to what is hard about changing paths in the output files - but I'm wondering, why would we need changing anyway? Is it because of mixed farms, etc?
Also, if this is a "local" submission - do we even need the IFD file? Or what's this about?
Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render. If it's a local render - then technically it can almost live in memory or transparently be in a temp folder on the local machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we need changing anyway? Is it because of mixed farms, etc?
As far as I know it's not only about mixed farms but also about having the IFD files with the correct data.
and keeping that link may produce IFD files that points to a wrong/non-existing geometry files.
Also, I doubt this problem is going to occur also with farm IFD publishing.
Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render.
I'm not sure about the why we have IFD family
I can obly remember it was added by @moonyuet in ynput/OpenPype#4903
Could @moonyuet you shed some light ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Containing all the geometry into the output file means you're basically bloating the filepath a lot. I really feel like this is the opposite of what a 'render' file should look like - it should be a lightweight file whenever possible.
I understand the comment as to what is hard about changing paths in the output files - but I'm wondering, why would we need changing anyway? Is it because of mixed farms, etc?
Also, if this is a "local" submission - do we even need the IFD file? Or what's this about?
Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render. If it's a local render - then technically it can almost live in memory or transparently be in a temp folder on the local machine?
We can just remove the entire product type instead. i mean same thing has been raised by @fabiaserra before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I don't see a point to keep IFDs around, as opposed to ASS files which have more benefits as you can use them as an exchange format across the different Arnold plugins
client/ayon_core/hosts/houdini/plugins/publish/extract_mantra_ifd.py
Outdated
Show resolved
Hide resolved
has there been any progress or plans on separating the extraction/render of nodes from the publish? |
As far as I know, there hasn't no. Might be one for Dee Coureau (I dont know his Github handle). |
I'm waiting for the 0.3.0 breaking release (this week?) to update my fork and migrate to |
it's @dee-ynput |
Marking this PR as a draft in favor of this comment #75 (comment) |
I don't think that we want to publish IFDs at all. Let's remove it in another PR. |
Changelog Description
Mantra IFD extractor local submission was failing because its extractor didn't include
render_rop
Testing notes: