Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfile Template Builder: Allow Create Placeholder to define the 'active' state #774

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jul 13, 2024

Changelog Description

Workfile Template Builder: Allow Create Placeholder to define the 'active' state of the created instance.

Additional info

Example in Houdini using ynput/ayon-houdini#36

image

The template:

image

After template build:

image

Testing notes:

would be nice to test in Nuke and Maya if it does not break anything.
Use old template where are placeholders without active.
Use new template and try if it creates activated/deactivated instances based on the placeholder data.

  1. Test whether this works when creating create placeholders in other hosts, like:
  2. Existing create placeholders in an existing template should still work and default to active.

@iLLiCiTiT iLLiCiTiT changed the title Workfile Templates:: Allow Create Placeholder to define the 'active' state Workfile Template Builder: Allow Create Placeholder to define the 'active' state Jul 15, 2024
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, would be nice to test in Nuke and Maya if it does not break anything.

  • Use old template where are placeholders without active.
  • Use new template and try if it creates activated/deactivated instances based on the placeholder data.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jul 15, 2024

Code looks good, would be nice to test in Nuke and Maya if it does not break anything.

* Use old template where are placeholders without `active`.

* Use new template and try if it creates activated/deactivated instances based on the placeholder data.

Note: Maya does not have support for "Create" placeholders. Nonetheless, I added these testing notes to the PR description. 👍

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in Houdini.

@iLLiCiTiT iLLiCiTiT merged commit e970394 into ynput:develop Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants