-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workfile Template Builder: Allow Create Placeholder to define the 'active' state #774
Workfile Template Builder: Allow Create Placeholder to define the 'active' state #774
Conversation
…ault 'active' state of the created instance
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, would be nice to test in Nuke and Maya if it does not break anything.
- Use old template where are placeholders without
active
. - Use new template and try if it creates activated/deactivated instances based on the placeholder data.
Note: Maya does not have support for "Create" placeholders. Nonetheless, I added these testing notes to the PR description. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works in Houdini.
Changelog Description
Workfile Template Builder: Allow Create Placeholder to define the 'active' state of the created instance.
Additional info
Example in Houdini using ynput/ayon-houdini#36
The template:
After template build:
Testing notes:
and bugfix Creators: Remove legacy
pop
of the 'active' data on create of instance. ayon-houdini#41 )