Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke: openpype expose knobs validator - OP-8166 #85

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

tokejepsen
Copy link
Member

@tokejepsen tokejepsen commented Feb 16, 2024

Changelog Description

Port of ynput/OpenPype#6213

@ynbot ynbot added size/XS host: Nuke type: bug Something isn't working labels Feb 16, 2024
@tokejepsen tokejepsen changed the title Failsafe for exposed_knobs settings OP-8166 and OP-8164 ports Feb 16, 2024
@tokejepsen tokejepsen requested a review from iLLiCiTiT February 16, 2024 15:57
@tokejepsen tokejepsen force-pushed the bugfix/OP-8166_openpype-expose-knobs-validator branch from 94c7b7c to f9a70bc Compare February 19, 2024 09:09
@tokejepsen tokejepsen changed the title OP-8166 and OP-8164 ports Nuke: openpype expose knobs validator - OP-8166 Feb 19, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Feb 19, 2024

I don't think this is needed in ayon-core. Settings overrides do not work the same way as in OpenPype.

@tokejepsen
Copy link
Member Author

I don't think this is needed in ayon-core. Settings overrides do not work the same way as in OpenPype.

So if an existing production is using ayon now without the Exposed Knobs setting, what would happen?

@iLLiCiTiT
Copy link
Member

So if an existing production is using ayon now without the Exposed Knobs setting, what would happen?

In AYON you'll always get current settings model values. And if the settings model has the attribute, you'll get the value, in other words core version 1.1.1 will always get settings values compatible with model 1.1.1.

NOTE: That might not be true in case of addons which have settings in server_addons, because client code lives in core and does not have to be in sync on server with settings.

@tokejepsen
Copy link
Member Author

NOTE: That might not be true in case of addons which have settings in server_addons, because client code lives in core and does not have to be in sync on server with settings.

So we do have to merge this PR?
Dont mind whether we do or not, just need a decision. If its a problem, then its a quick and easy fix later.

@iLLiCiTiT
Copy link
Member

Dont mind whether we do or not, just need a decision. If its a problem, then its a quick and easy fix later.

Huge sorry, I just realized the change is in nuke and not in core settings. Yes we should merge this.

@iLLiCiTiT iLLiCiTiT merged commit aaa1ac0 into develop Feb 19, 2024
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-8166_openpype-expose-knobs-validator branch February 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants