-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong retimed detection on image sequence clip. #897
Fix wrong retimed detection on image sequence clip. #897
Conversation
For the testing data, we also need to check the retime effects (LinearTimeWarp, FreezeFrame, TimeEffect). Since the method name relates to retiming, this will cover the full range of functions. Great job on practically developing the unittest we really need! I'm thinking about whether we should add the test to the appropriate folder. @kalisp and @antirotor could lend a hand here, especially since |
Before the introduction of Resolve's native OTIO, we mainly relied on two attributes:
With Resolve's interpretation of OTIO now in play, we consider:
We reference the media source to an absolute value with included metadata because of FFMPEG. Since we use FFMPEG for video trimming, it's crucial to have the timecode correctly defined. First, figure out if the clip source range is relative or absolute to the media range. Next, find the relative source frame value and continue as before, making sure to clear up any confusing code that's mistakenly referring to me (old me 😄). |
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
but it can - I added one for my own tests, see feature/OP-1188_better-representation-model branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok. @jakubjezek001 merge if is ready please.
Fix extract_otio_review extraction logic for corner-case media
for project_name\nUpdate Anatomy NamedTuple to specify project_name as string type. This change ensures consistency and clarity in the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests in Hiero didn't go well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @robin-ynput ! Thanks a lot! 💫 💥
Changelog Description
This PR addresses the bug described on #895 regarding retiming OTIO clip from image sequence.
Testing notes:
Environment prep
ayon-core\client\pyproject.toml
into root level pyproject.toml under tool.poetry.dev-dependenciesayon-core\poetry.lock
.\tools\manage.ps1 create-env
(windows)Testing
run
.\tools\manage.ps1 run pytest .\tests\client\ayon_core\pipeline\editorial\
(windows)AY-979