-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extract_otio_review extraction logic for corner-case media #916
Merged
iLLiCiTiT
merged 9 commits into
bugfix/#895_fix_otio_subset_resources_img_sequence
from
bugfix/#895_fix_extract_otio_review
Oct 2, 2024
Merged
Fix extract_otio_review extraction logic for corner-case media #916
iLLiCiTiT
merged 9 commits into
bugfix/#895_fix_otio_subset_resources_img_sequence
from
bugfix/#895_fix_extract_otio_review
Oct 2, 2024
+2,280
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
robin-ynput
changed the title
Fix extract otio review
Fix extract_otio_review extraction logic for corner-case media
Sep 24, 2024
14 tasks
iLLiCiTiT
reviewed
Sep 25, 2024
Task linked: OP-8066 Resolve: update to new publisher |
jakubjezek001
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested it via pytests and Resolve native OTIO file and all worked as expected. Perfect!
iLLiCiTiT
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR addresses: #912
The OTIO extraction logic set in
extract_otio_review
had some flaws when dealing with those corner cases:Which often would give an "out-of-range" error in
FFmpeg
extraction.This PR adjust the extraction logic in order to accomodate those cases, similarly to what was already done for
Collect OTIO subset
on #897Testing notes:
pytest "path/to/your/ayon_core/pipeline/editorial
AY-979
closes #912