Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extract_otio_review extraction logic for corner-case media #916

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Sep 24, 2024

Changelog Description

This PR addresses: #912

The OTIO extraction logic set in extract_otio_review had some flaws when dealing with those corner cases:

  • media with embedded timecode metadata
  • media source range and available range of different rate
  • image sequence media with embedded frame rate metadata

Which often would give an "out-of-range" error in FFmpeg extraction.
This PR adjust the extraction logic in order to accomodate those cases, similarly to what was already done for Collect OTIO subset on #897

Testing notes:

  1. Run the unit tests
    pytest "path/to/your/ayon_core/pipeline/editorial

AY-979

closes #912

@ynbot ynbot added type: bug Something isn't working size/XL labels Sep 24, 2024
@robin-ynput robin-ynput marked this pull request as ready for review September 24, 2024 21:29
@robin-ynput robin-ynput self-assigned this Sep 24, 2024
@robin-ynput robin-ynput changed the title Fix extract otio review Fix extract_otio_review extraction logic for corner-case media Sep 24, 2024
@ynbot
Copy link
Contributor

ynbot commented Sep 25, 2024

Task linked: OP-8066 Resolve: update to new publisher

@jakubjezek001 jakubjezek001 self-assigned this Sep 25, 2024
@robin-ynput robin-ynput self-assigned this Sep 25, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested it via pytests and Resolve native OTIO file and all worked as expected. Perfect!

@iLLiCiTiT iLLiCiTiT merged commit 1072fc9 into bugfix/#895_fix_otio_subset_resources_img_sequence Oct 2, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/#895_fix_extract_otio_review branch October 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix extract_otio_review plugins to accomodate image sequence and media with embedded timecode
5 participants