-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publisher: Display overridden vs default values of attributes #982
Publisher: Display overridden vs default values of attributes #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this!
I do think this should absolutely come with a means to "reset to defaults" so that one could easily learn also that the color hinting means that it's "not at default value". But it does work very nice! Great work. Here's a good reference on revert to defaults.
I would almost go as far as saying it should be part of this PR - but I'm technically fine with it as a follow up PR.
@iLLiCiTiT should we somehow dim the color if it's 'disabled'? (This is e.g. after publishing, before reset) And, the orange color is relatively 'negative'. Should we use the "green" color for saved studio override settings on web frontend instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, the only occasion which throw some traceback is when trying to switch settings for context
and Validate outdated containers
resulting in
// Traceback (most recent call last):
// File "C:\Work\REPO\ayon-core\client\ayon_core\lib\events.py", line 332, in process_event
// callback(event)
// File "c:\Work\REPO\ayon-maya\client\ayon_maya\plugins\create\create_maya_usd.py", line 30, in on_values_changed
// if instance["creator_identifier"] != self.identifier:
// TypeError: 'NoneType' object is not subscriptable
Not failing but worth mentioning imho....
Thanks - that's actually a bug outside of this PR then. I'll fix it. 👍 |
I've changed color to the "greenish" one, and with that I would keep it even if is disabled. But I don't have strong opinion about this, should be easy to change.
Separate issue, this was easy, reverting might be a little but more complicated. |
Just adding some screenshots with latest changes: Looking really nice. I'd say, ready to merge - except maybe last debate on the chosen color? I do wonder whether Green or Orange is the best color pick here. Artist here said "looks like an approved value". Maybe the blue tint would still be better? |
I like blue the most. |
Changelog Description
Visualy display if value of attributes on instance does not match default value.
Additional info
It should also behave correctly on multiselection of instances even if they don't have same default values. But if at least one of selected instances does not use default value it is shown as overriden.
Testing notes:
Resolves #139