Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Don't override already set env variables #67

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Chore: Don't override already set env variables #67

merged 2 commits into from
Nov 25, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Collect farm env variables does not override already set environment variables.

Testing notes:

  1. Environment variables should be passed to jobs correctly.

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 25, 2024
@iLLiCiTiT iLLiCiTiT requested review from BigRoy and kalisp November 25, 2024 11:01
@iLLiCiTiT iLLiCiTiT mentioned this pull request Nov 25, 2024
Merged
BigRoy
BigRoy approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

client/ayon_deadline/plugins/publish/global/collect_deadline_job_env_vars.py Show resolved Hide resolved
@iLLiCiTiT iLLiCiTiT merged commit 1df52ae into develop Nov 25, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/do-not-override-already-set-envs branch November 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @BigRoy