-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AY-6253_Convert Flame creators to new publisher #33
Conversation
005ed37
to
86f3c66
Compare
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
The PR looks solid to me. After a short testing session, I have the following notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR look already great but I have to request some changes regarding the Reviewable source distribution enhancements.
@jakubjezek001 I have started a draft PR aside for the review work: For the marker comment, I couldn't find any API to delete markers from within Flame hence the empty marker for now. |
Not aware of any solution for it. Lets keep them there for now. Users should do it manualy. We can add warning into documentation. |
AY-6253_Report review changes from Hiero to Flame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! it works well now and it is good to be merged! Thank you!
Changelog Description
resolve #10
Make flame creators use the Creator API and new widget. Publishable products are now listed as individual instances following a similar logic than Hiero and Resolve.
Done:
colorspace
data following Update metadata keys and add colorspace data ayon-hiero#23Testing notes:
In Flame:
Tested locally on Flame 2024.2
resolves #25
AY-6253