Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AY-6253_Report review changes from Hiero to Flame #36

Merged
merged 8 commits into from
Dec 5, 2024
Merged

AY-6253_Report review changes from Hiero to Flame #36

merged 8 commits into from
Dec 5, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Dec 2, 2024 •
edited by jakubjezek001
Loading

Changelog Description

Report reviewable changes from Hiero to Flame

Additional review information

This report the following changes from Hiero:

And need to be tested alongside: ynput/ayon-core#1036

Testing notes:

  1. Open Hiero and create instance(s) through the Create Publishable Clip
  2. Set the review source media to [Clip media]
    image
  3. Publish and ensure that the resulting review product is created from the original clip media entire range (untrimmed)

AY-6253

@robin-ynput robin-ynput marked this pull request as ready for review December 3, 2024 22:47
@robin-ynput robin-ynput added the type: enhancement Improvement of existing functionality or minor addition label Dec 3, 2024
@robin-ynput robin-ynput self-assigned this Dec 3, 2024
@jakubjezek001 jakubjezek001 changed the title Report review changes from Hiero to Flame AY-6253_Report review changes from Hiero to Flame Dec 5, 2024
jakubjezek001
jakubjezek001 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@jakubjezek001 jakubjezek001 merged commit 6e0e676 into 10_creator_new_publisher Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@robin-ynput robin-ynput

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin-ynput @jakubjezek001