Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame 2025 support #53

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Liametc
Copy link

@Liametc Liametc commented Feb 4, 2025

Changelog Description

removing user flags if flame year is 2025 or above

Additional review information

This relates to #51 where flame 2025 has removed user profiles and getting the user name using wiretap is broken as a result.

Testing notes:

  1. Launch flame 2025 - No errors when loading should occur
  2. Launch on earlier versions of flame - user profile should be created

@Liametc Liametc force-pushed the bugfix/51-flame_2025_support branch from 426b6aa to ae84b0a Compare February 4, 2025 12:21
@BigRoy BigRoy linked an issue Feb 5, 2025 that may be closed by this pull request
1 task
@BigRoy BigRoy added the type: bug Something isn't working label Feb 5, 2025
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks @Liametc !

@robin-ynput
Copy link
Contributor

Code changes look good, thanks a lot for this !
I'm waiting on some installs just so I can double check it with a fresh Flame 2025 on our end.

@robin-ynput robin-ynput added the community Issues and PRs coming from the community members label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flame 2025 has changed the need to create user profiles
4 participants