Create correct Hdas from Subnetworks, keeping Parms, Outputs and Inputs.

[Lypsolon]

Changelog Description

This PR automatically detects how many outputs are present in an subnet and how many inputs are connected to any node. it also moves all the parms from a subnet over to the generated hda.
the Parms, inputs and outputs are kept intact when generating an HDA from an Subnet by copy pasting them over.

• test if some expressions might get broken by copy pasting them.

Additional review information

Old Behavior

• when creating an HDA from an Subnet the outputs of the hda will be set to 1 and the inputs to 0.
• when creating an HDA from a Subnet the parms will be deleted.
• if you change the inputs of the HDA from the type definition the inputs will survive into the published hda

New Behavior

• check the indirect inputs of the selected subnet and check if those inputs have a node connected to them. we will then count the subnet inputs that have a node connected (inside the subnet not tpo layer) and set the max inputs of the HDA.
• we then collect the Output nodes and check if there index is unique (Houdini dose not allow you to create multiple output nodes with the same index but you could create them and then create a HDA this would then internally error.) from this list we then set the HDA outps (we need to set the HDA outputs in there HDA definition after the creation because Houindi dose not offer a parameter in the .CreateHda() function from hou.Node class
• we copy the parameter template from the source subnet into a tempVar before we create the hda from it. then we simply add the template onto the hda definition.

Testing notes:

1. Create a subnet add a few output nodes and connect what ever you want to the input nodes of the subnet(internally not the external ones)
2. Ayon -> Create -> Create HDA
3. check if all your connections still function correctly and if the right inputs outputs and prams exist. also check if relative parm references and parm expressions still work as expected.

extra points:

• create an hda from a selection of nodes and check if this works.

[BigRoy]

Is it correct that this draft PR is ONLY code style changes currently - or what am I missing?

[Lypsolon]

Is it correct that this draft PR is ONLY code style changes currently - or what am I missing?

i always create a PR right away, this is how GitLab works and i believe its simply better in all ways.

also i forgot to push the changes yesterday.

[MustafaJafar]

Hello,
I've created another PR #172 based on the changes on this PR.

[MustafaJafar]

closing this PR in favor of #172