Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

174 cleanup pointcache and model families #175

Merged
merged 2 commits into from
Nov 18, 2024
Merged

174 cleanup pointcache and model families #175

merged 2 commits into from
Nov 18, 2024

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

resolve #174

Note

This is a smaller version of #149 without the changes related to deadline.

Testing notes:

  1. publishing pointcaches and model should work as before.

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Nov 16, 2024
@MustafaJafar MustafaJafar self-assigned this Nov 16, 2024
BigRoy
BigRoy approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I actually think this is ALSO a good moment to start changing the bgeo and abc family to rop.geometry and rop.alembic. What do you think?

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Nov 16, 2024 •
edited
Loading

Looks good to me.

I actually think this is ALSO a good moment to start changing the bgeo and abc family to rop.geometry and rop.alembic. What do you think?

rop.geometry is also used for exporting vdb caches.

I think I'll enjoy doing some cleaning up.

@moonyuet
Copy link
Member

Looks good to me.
I actually think this is ALSO a good moment to start changing the bgeo and abc family to rop.geometry and rop.alembic. What do you think?

rop.geometry is also used for exporting vdb caches.

I think I'll enjoy doing some cleaning up.

we can have rop.vdb family for exporting vdb, instead of rop.geometry.

moonyuet
moonyuet approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. And guess it is ready for the merge?

@MustafaJafar MustafaJafar merged commit 03f7b76 into develop Nov 18, 2024
1 check passed
@MustafaJafar MustafaJafar deleted the 174-cleanup-pointcache-and-model-families branch November 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@moonyuet moonyuet moonyuet approved these changes

Assignees

@MustafaJafar MustafaJafar

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup pointcache and model families
3 participants
@MustafaJafar @moonyuet @BigRoy