Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD Render: prefix the AOV with the render product name #178

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Nov 19, 2024

Changelog Description

prefix the AOV with the render product name.
Hopefully, resolve #105

Note

This PR was made to show the issue where different render products can export the same render var(AOV) but with different configurations, such as Beauty and Deep Beauty.
In this essence, the publisher is not creating enough instances for them and just keep showing this error message:

Multiple render products are identified as the same AOV 
which means one of the two will not be ingested during 
publishing. AOV: '%s'", aov_identifier

Important

For this PR to be merged, we need to ensure it's backwards compatible
where the layers shouldn't get a new name or being too long and cluttered.

Additional Info

Here's an example scene. Please let me now if it's not a good example scene.
Expr_USD_Render_Houdini_v001.zip

Demo

Here are some screenshots.

When Dcm has one AOV
image

When Dcm has multiple AOVs
image

Testing notes:

  1. Add multiple render vars and multiple products.
  2. Feel free to us the same render var within different render products.
  3. Publish USD render.

@MustafaJafar MustafaJafar added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Nov 19, 2024
@MustafaJafar MustafaJafar self-assigned this Nov 19, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
image

@MustafaJafar MustafaJafar marked this pull request as draft November 20, 2024 09:26
@MustafaJafar
Copy link
Contributor Author

Closing this PR in favor of #120

@MustafaJafar MustafaJafar deleted the 105-houdini-usd-render-rop-publish-when-dcm-is-enabled branch November 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Houdini USD Render Rop publish when DCM is enabled
2 participants