Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support render targets for cache instances #180

Merged

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Nov 20, 2024

Changelog Description

resolve #19
Support render targets for the following products: (I'll add them by creators)

  • Alembic camera
  • Arnold ass
  • Pointcache Bgeo
  • Model
  • Pointcache Abc
  • Redshift proxy
  • Review
  • Static Mesh
  • USD (it works with contribution workflow. users should wait the publish before loading the usd asset)
  • USD Look (it works with contribution workflow, users should wait the publish before loading the usd asset))
  • VDB Cache

Note

When supporting render targets for Houdini CompositeSequence (Cop Node), composite instances triggers Submit Image Publishing job to Deadline along Submit cache jobs to Deadline because the instance has both imagesequence and publish.hou families.
Here's an issue for it #183

This means that supporting Cop Nodes will need to go through the render submitting logic instead of cache submitting logic.
image

Testing notes:

  1. Try publishing different cache instances with different render targets

@MustafaJafar MustafaJafar added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Nov 20, 2024
@MustafaJafar MustafaJafar changed the title support render targets for bgeo instances Support render targets for bgeo instances Nov 20, 2024
@MustafaJafar MustafaJafar self-assigned this Nov 20, 2024
Co-authored-by: Roy Nieterau <[email protected]>
@MustafaJafar MustafaJafar changed the title Support render targets for bgeo instances Support render targets for cache instances Nov 22, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and test successfully in Houdini.

@MustafaJafar MustafaJafar merged commit bbba2a4 into develop Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish existing caches
3 participants