generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support render targets for cache instances #180
Merged
MustafaJafar
merged 7 commits into
develop
from
enhancement/support-render-targets-for-bgeo-instances
Nov 26, 2024
Merged
Support render targets for cache instances #180
MustafaJafar
merged 7 commits into
develop
from
enhancement/support-render-targets-for-bgeo-instances
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaJafar
added
type: enhancement
Improvement of existing functionality or minor addition
community
Issues and PRs coming from the community members
labels
Nov 20, 2024
MustafaJafar
changed the title
support render targets for bgeo instances
Support render targets for bgeo instances
Nov 20, 2024
BigRoy
reviewed
Nov 21, 2024
BigRoy
reviewed
Nov 21, 2024
BigRoy
reviewed
Nov 21, 2024
Co-authored-by: Roy Nieterau <[email protected]>
moonyuet
reviewed
Nov 22, 2024
MustafaJafar
changed the title
Support render targets for bgeo instances
Support render targets for cache instances
Nov 22, 2024
1 task
moonyuet
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and test successfully in Houdini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Issues and PRs coming from the community members
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve #19
Support render targets for the following products: (I'll add them by creators)
Note
When supporting render targets for Houdini
CompositeSequence
(Cop Node), composite instances triggersSubmit Image Publishing job to Deadline
alongSubmit cache jobs to Deadline
because the instance has bothimagesequence
andpublish.hou
families.Here's an issue for it #183
This means that supporting Cop Nodes will need to go through the render submitting logic instead of cache submitting logic.
Testing notes: