-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asset HDA LOP: Implement and use select product dialog #39
asset HDA LOP: Implement and use select product dialog #39
Conversation
Thanks @MustafaJafar I personally like it less because it's further away from where you click so I have a feeling it's less quick this way, usually. But I'm fine with merging it if everyone likes it. Could you add a screen recording on how it behaves without this PR? That way anyone can just quickly comment on the visual differences on how it behaves. |
Had another look - I actually love that this removes the Product Type parm. Simplifies a lot of things. However, I would love for the dialog to feel more like a dropdown menu so that it popups near the clicked location so that it behaves similar to what Houdini does or right click context menus do. I'll look into that. |
@BigRoy , I almost forgot about this PR 😄 |
I've had it in my mind - just not at high priority... but looking at the fact that I'm now creating more HDAs.. maybe I do want to focus on this rather sooner than later. Hmm... hopefully later this week before my vacation. |
So, what is missing according to your comment #39 (comment) above is to place the window near the mouse position. def showEvent(self, event):
# Position the window near the mouse position
pos = QtGui.QCursor.pos()
geo = QtCore.QRect(pos.x(), pos.y())
self.setGeometry(geo)
return super(SelectFolderPathDialog, self).showEvent(event) |
…r the mouse. Also auto-select the current value if any matches.
…string to function
@MustafaJafar I've pushed some changes could you give it a go and of course, break it if possible? |
Changelog description
Use dialog to pick product and remove redundant Houdini parameter.
Additional info
There's a bug where the representation name is not updating. I can reproduce it in develop branch.
oh, there's an issue for it already #32
Testing Notes: