Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset HDA LOP: Implement and use select product dialog #39

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Jul 11, 2024

Changelog description

Use dialog to pick product and remove redundant Houdini parameter.

Animation_88

Additional info

There's a bug where the representation name is not updating. I can reproduce it in develop branch.
oh, there's an issue for it already #32

Testing Notes:

  1. use asset lop.
  2. try the product picker.
  3. everything should work as usual.

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Jul 11, 2024
@MustafaJafar MustafaJafar marked this pull request as draft July 11, 2024 16:16
@MustafaJafar MustafaJafar marked this pull request as ready for review July 11, 2024 16:34
@BigRoy
Copy link
Contributor

BigRoy commented Jul 11, 2024

Thanks @MustafaJafar

I personally like it less because it's further away from where you click so I have a feeling it's less quick this way, usually. But I'm fine with merging it if everyone likes it.

Could you add a screen recording on how it behaves without this PR? That way anyone can just quickly comment on the visual differences on how it behaves.

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Jul 11, 2024

Could you add a screen recording on how it behaves without this PR? That way anyone can just quickly comment on the visual differences on how it behaves.

I already have that, let me add them here

  • Before
    Animation_8
  • After
    Animation_88

@BigRoy
Copy link
Contributor

BigRoy commented Jul 12, 2024

Had another look - I actually love that this removes the Product Type parm. Simplifies a lot of things.

However, I would love for the dialog to feel more like a dropdown menu so that it popups near the clicked location so that it behaves similar to what Houdini does or right click context menus do. I'll look into that.

@BigRoy BigRoy self-assigned this Jul 12, 2024
@MustafaJafar
Copy link
Contributor Author

@BigRoy , I almost forgot about this PR 😄

@BigRoy
Copy link
Contributor

BigRoy commented Jul 29, 2024

@BigRoy , I almost forgot about this PR 😄

I've had it in my mind - just not at high priority... but looking at the fact that I'm now creating more HDAs.. maybe I do want to focus on this rather sooner than later. Hmm... hopefully later this week before my vacation.

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Jul 30, 2024

@BigRoy , I almost forgot about this PR 😄

I've had it in my mind - just not at high priority... but looking at the fact that I'm now creating more HDAs.. maybe I do want to focus on this rather sooner than later. Hmm... hopefully later this week before my vacation.

So, what is missing according to your comment #39 (comment) above is to place the window near the mouse position.
I'm a little noob.
I was able to get the mouse location, but no idea how to set the location correctly.

    def showEvent(self, event):
        # Position the window near the mouse position 
        pos = QtGui.QCursor.pos()
        geo = QtCore.QRect(pos.x(), pos.y())
        self.setGeometry(geo)

        return super(SelectFolderPathDialog, self).showEvent(event)

@BigRoy
Copy link
Contributor

BigRoy commented Jul 30, 2024

@MustafaJafar I've pushed some changes could you give it a go and of course, break it if possible?

image

@MustafaJafar MustafaJafar merged commit f5c5ea8 into develop Jul 30, 2024
1 check passed
@BigRoy BigRoy deleted the enhancement/asset-lop-add-pick-product-dialog branch July 30, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants