Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Activate host color management by default #48

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Active Host Color Management for Houdini by default.

Additional info

This value is only relevant if in ayon core you have Global Color Management enabled. However, Houdini was the only application that had an application specific activate_host_color_management defaulting to False - even though others all have it True.

This meant that by default if you enabled Global Color Management it would still remain disabled for Houdini unless this toggle was checked. That's straight up confusing.

This may need to come with a minor bump and clear statement in the release notes - because they may be edge cases where a studio can get bit by this if they relied on the previous disabled state but had Global Color Management enabled.

Testing notes

  1. New default value should work

@BigRoy BigRoy added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Jul 17, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Approve == It works as excepted on my end.
But, I can't help on decision making. because I'm not aware of what studios are used to do. Maybe we can summon @m-u-r-p-h-y

This may need to come with a minor bump and clear statement in the release notes - because they may be edge cases where a studio can get bit by this if they relied on the previous disabled state but had Global Color Management enabled.

If they are copying settings values from the existent Houdini addon on their end, would it override the activate_host_color_management value ?
No, it won't if they kept it off by default. Here's a screenshot where It's not visible.
image

Maybe we can just pass the pain to the backend repo as the copy settings tool doesn't inform users about the change in default settings.
256dd183e023748f24f3cb6e044c1f96

@MustafaJafar MustafaJafar requested a review from m-u-r-p-h-y July 18, 2024 15:22
…ancement/activate_host_color_management_by_default

# Conflicts:
#	server/settings/imageio.py
@iLLiCiTiT iLLiCiTiT merged commit 743a7ee into ynput:develop Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants