Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong name when calling setName #62

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Follow up PR to #61
as we missed to fix the name when updating the node names

Testing notes:

  1. update load placeholder, use a regex pattern not only a plain str.

@MustafaJafar MustafaJafar added the type: bug Something isn't working label Aug 2, 2024
@MustafaJafar MustafaJafar requested review from BigRoy and moonyuet August 2, 2024 12:44
@MustafaJafar MustafaJafar self-assigned this Aug 2, 2024
@MustafaJafar MustafaJafar linked an issue Aug 2, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on discord, this looks like the right fix. :)

For context: docs on hou.text are here https://www.sidefx.com/docs/houdini/hom/hou/text.html

@MustafaJafar MustafaJafar merged commit 93e9810 into develop Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating placeholders fail whn using a regex pattern instead of a plain string.
2 participants