Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <br> in validator reports for new lines #227

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 29, 2025

Changelog Description

Replace <br> in validator reports for new lines log reports

Additional review information

Since ynput/ayon-core#1104 the <br> would also display directly in the publisher UI report - which would appear cluttered. However, even without that PR the command line output would've also had the <br> in there so removing them is the correct fix.

image

image

image

Testing notes:

  1. Validate Mesh UV output should look good
  2. Validate Transform Naming Suffix report should look good ayon+settings://maya/publish/ValidateTransformNamingSuffix
  3. Validate Transform Zero report should look good. ayon+settings://maya/publish/ValidateTransformZero

@BigRoy BigRoy added the type: bug Something isn't working label Jan 29, 2025
@BigRoy BigRoy self-assigned this Jan 29, 2025
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the testing steps, all 1, 2 , 3 occasion worked well and formatting was accurate/ nice to look at.

Havent spotted any issues, so good to go!

One example from the testing here:

Screenshot 2025-01-30 101127

@BigRoy BigRoy merged commit 1d29cc7 into ynput:develop Jan 30, 2025
1 check passed
@BigRoy BigRoy deleted the bugfix/report_log_avoid_br branch January 30, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants