Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use task attributes for WorkfileSettings #13

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Aug 26, 2024

Changelog Description

Workfile resolution and FPS is now set using the current task's entity attribute instead of from the parent folder entity.

Additional info

I didn't test it.

Testing notes:

Create a folder with a task where the task has different FPS and resolution.

  1. Create new workfile - settings should adhere to task attributes
  2. Use "Reset resolution" and "Reset frame range" menu actions - it should set it using the task attributes
  3. Publishing validations should also adhere to the task attributes, not the folder entity attributes. (If there are any validators for that.)

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Aug 26, 2024
@BigRoy BigRoy requested review from antirotor and moonyuet August 26, 2024 09:20
@BigRoy BigRoy self-assigned this Aug 26, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to publish the workfile, it errors out.

Traceback (most recent call last):
  File "C:\Users\Kayla\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "D:\ayon-addon_template\ayon-nuke\client\ayon_nuke\plugins\publish\validate_script_attributes.py", line 37, in process
    src_attributes = task_entity["attributes"]
KeyError: 'attributes'

@BigRoy BigRoy requested a review from moonyuet August 26, 2024 11:53
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validator looks good now. And the task frame range being set correctly too.
image

@moonyuet moonyuet merged commit 7a08f57 into develop Aug 26, 2024
1 check passed
@moonyuet moonyuet deleted the enhancement/use_task_attributes branch August 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants