Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke behavior more resilient #36

Merged

Conversation

jrsndl
Copy link

@jrsndl jrsndl commented Oct 23, 2024

Changelog Description

Ayon uses onScriptSave callback to update nodes' colors. If this fails by any reason, artist is not able to save the file.

Nuke sometimes fails on getting knob type needed in read_avalon_data. This can result in artisn not being able to open workfile. Reason unknown, hard to test.

Changes allow artist to continue working.

Additional info

Might close #33

Testing notes:

  1. Launch Nuke, open Workfile
  2. Make changes
  3. Stop server
  4. Save file with Control + S

@jakubjezek001 jakubjezek001 added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Oct 24, 2024
@jakubjezek001 jakubjezek001 self-assigned this Oct 24, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@jakubjezek001 jakubjezek001 merged commit 17bdc4d into ynput:develop Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AYON 'onScriptSave' callback can block saving workfile if it errors
2 participants