Easier Addon Setting for Nodes settings in color management section #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaJafar
added
the
type: enhancement
|
Also, I'd like to point out that when adding new creator plugins, we should update the two enums accordingly. |
robin-ynput
approved these changes
Nov 25, 2024
| {"value": "Camera2", "label": "Camera [3D Classic]"}, | ||
| {"value": "Scene", "label": "Scene [3D Classic]"}, | ||
| {"value": "BackdropNode", "label": "Backdrop [Other]"}, | ||
| ] |
There was a problem hiding this comment.
Potentially not for this PR, but I'm wondering if there is a way to make these enums dynamically retrieved ?
We would need to add a class attribute to each creator to get the associated Nuke node Class and gather the creators.
Benefit imo would be that we get server settings follow code adjustments.
There was a problem hiding this comment.
I'd love to!
I don't know if we can the client side of ayon_nuke in the server side.
Let's summon our server guardian @martastain
…s-in-color-management-section
MustafaJafar
deleted the
42-easier-addon-setting-for-nodes-settings-in-color-management-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve #42
Reuse the names/labels that admins/nuke artists are familiar with.
where the setting shows a drop down menu and select the creators
Note
Settings in this PR should be backward compatible. i.e. it shouldn't break copy settings.
If it's not please report.
Additional Info
I was modifying the code to take a neat screenshot but it turns out that the small modification actually works without changing any code or even default setting values.
Testing notes: